Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[Windows] Move to FlutterCompositor for rendering #48849

Merged
auto-submit merged 11 commits into from
Dec 13, 2023
Merged

[Windows] Move to FlutterCompositor for rendering #48849

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
dda3ab0
[Windows] Move to `FlutterCompositor` for rendering
loic-sharma Dec 4, 2023
782dc4d
Remove unused mock
loic-sharma Dec 9, 2023
5611ca6
Add new line
loic-sharma Dec 9, 2023
6cc972e
Clean
loic-sharma Dec 9, 2023
46d692c
Update licenses
loic-sharma Dec 9, 2023
69b6586
More tests
loic-sharma Dec 9, 2023
6eb7fa0
Switch to calloc
loic-sharma Dec 11, 2023
fcf0365
Address some feedback
loic-sharma Dec 12, 2023
498825b
Document why destruction_callback is empty
loic-sharma Dec 12, 2023
215db1b
Feedback
loic-sharma Dec 13, 2023
aea1725
Refactor
loic-sharma Dec 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove unused mock
  • Loading branch information
@loic-sharma
loic-sharma committed Dec 13, 2023
commit 782dc4d9f1253c685ca34c4fcbf677013345703d
6 changes: 0 additions & 6 deletions shell/platform/windows/compositor_opengl_unittests.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,6 @@ const unsigned char* MockGetString(GLenum name) {
}
}

const unsigned char* MockGetStringi(GLenum name, GLuint index) {
return (unsigned char*)"";
}

void MockGetIntegerv(GLenum name, int* value) {
*value = 0;
}
Expand All @@ -45,8 +41,6 @@ void DoNothing() {}
const impeller::ProcTableGLES::Resolver kMockResolver = [](const char* name) {
if (strcmp(name, "glGetString") == 0) {
return reinterpret_cast<void*>(&MockGetString);
} else if (strcmp(name, "glGetStringi") == 0) {
return reinterpret_cast<void*>(&MockGetStringi);
} else if (strcmp(name, "glGetIntegerv") == 0) {
return reinterpret_cast<void*>(&MockGetIntegerv);
} else if (strcmp(name, "glGetError") == 0) {
Expand Down