Start of tests

impeller/compiler/BUILD.gn

@@ -105,6 +105,7 @@ impeller_component("compiler_unittests") {
     "compiler_test.cc",
     "compiler_test.h",
     "compiler_unittests.cc",
+    "shader_bundle_unittests.cc",
     "switches_unittests.cc",
   ]
 

impeller/compiler/shader_bundle.cc

@@ -15,8 +15,8 @@
 namespace impeller {
 namespace compiler {
 
-static std::optional<ShaderBundleConfig> ParseShaderBundleConfig(
-    std::string& json_config) {
+std::optional<ShaderBundleConfig> ParseShaderBundleConfig(
+    const std::string& json_config) {
   auto json = nlohmann::json::parse(json_config);
   if (!json.is_object()) {
     std::cerr << "The shader bundle must be a JSON object." << std::endl;

impeller/compiler/shader_bundle.h

@@ -8,6 +8,9 @@
 namespace impeller {
 namespace compiler {
 
+std::optional<ShaderBundleConfig> ParseShaderBundleConfig(
+    const std::string& json_config);
+
 bool GenerateShaderBundle(Switches& switches, SourceOptions& options);
 
 }  // namespace compiler

impeller/compiler/shader_bundle_unittests.cc

@@ -0,0 +1,24 @@
+// Copyright 2013 The Flutter Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include <initializer_list>
+#include <vector>
+
+#include "impeller/compiler/shader_bundle.h"
+
+#include "flutter/testing/testing.h"
+
+namespace impeller {
+namespace compiler {
+namespace testing {
+
+TEST(ShaderBundleTest, ShaderBundleConfigFailsForInvalidJSON) {
+  std::string bundle = "";
+  auto result = ParseShaderBundleConfig(bundle);
+  ASSERT_FALSE(result.has_value());
+}
+
+}  // namespace testing
+}  // namespace compiler
+}  // namespace impeller

impeller/compiler/switches_unittests.cc

@@ -80,6 +80,19 @@ TEST(SwitchesTEst, ConvertToEntrypointName) {
   ASSERT_EQ(ConvertToEntrypointName(""), "");
 }
 
+TEST(SwitchesTest, ShaderBundleModeValid) {
+  // Shader bundles process multiple shaders, and so the single-file input/spirv
+  // flags are not required.
+  std::vector<const char*> options = {
+      "--shader-bundle={}", "--sl=test.shaderbundle", "--runtime-stage-metal"};
+
+  auto cl = fml::CommandLineFromIteratorsWithArgv0("impellerc", options.begin(),
+                                                   options.end());
+  Switches switches(cl);
+  ASSERT_TRUE(switches.AreValid(std::cout));
+  ASSERT_EQ(switches.shader_bundle, "{}");
+}
+
 }  // namespace testing
 }  // namespace compiler
 }  // namespace impeller