Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Attempt to cure goldens.
  • Loading branch information
ditman committed Dec 19, 2023
commit 526e186d53a4b81ee312900cb974b875bd76a7cb
7 changes: 3 additions & 4 deletions lib/web_ui/lib/src/engine/canvaskit/embedded_views.dart
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,9 @@ class HtmlViewEmbedder {
/// If this returns a [CkCanvas], then that canvas should be the new leaf
/// node. Otherwise, keep the same leaf node.
CkCanvas? compositeEmbeddedView(int viewId) {
// Ensure platform view with `viewId` is injected into the `rasterizer.view`.
rasterizer.view.dom.injectPlatformView(viewId);

final int overlayIndex = _context.visibleViewCount;
_compositionOrder.add(viewId);
// Keep track of the number of visible platform views.
Expand All @@ -143,10 +146,6 @@ class HtmlViewEmbedder {
}

void _compositeWithParams(int platformViewId, EmbeddedViewParams params) {
// Ensure platform view with `platformViewId` is injected into the `rasterizer.view`
// before rendering its shadow DOM `slot`.
rasterizer.view.dom.injectPlatformView(platformViewId);

// If we haven't seen this viewId yet, cache it for clips/transforms.
final ViewClipChain clipChain = _viewClipChains.putIfAbsent(platformViewId, () {
return ViewClipChain(view: createPlatformViewSlot(platformViewId));
Expand Down