Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@matanlurey
Copy link
Contributor

@matanlurey matanlurey commented Dec 14, 2023

For consistency, I don't think we have any other tools with -'s.

I'll be honest - this seemed easier than teaching the header guard tool how to handle -'s in directory names, but if you feel strongly about it I can revert.

@jason-simmons
Copy link
Member

Changing the name of the source directory to font_subset for consistency makes sense.

But the binary name font-subset is expected by downstream consumers like flutter_tools and would require a coordinated update. I'd recommend keeping that as is.

@matanlurey
Copy link
Contributor Author

But the binary name font-subset is expected by downstream consumers like flutter_tools and would require a coordinated update. I'd recommend keeping that as is.

Makes sense. Done. PTAL!

@matanlurey
Copy link
Contributor Author

Oops I messed something up with this PR (merged weird or something). Fixing...

@matanlurey matanlurey closed this Dec 14, 2023
@matanlurey matanlurey force-pushed the engine-underscore-font-subset branch from 9a6485b to 45b95f2 Compare December 14, 2023 21:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

No open projects
Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants