Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Turn on scenario app screenshots #49066

Merged
auto-submit merged 3 commits into from
Dec 21, 2023
Merged

Turn on scenario app screenshots #49066

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3a5e461
Turn on scenario app screenshots
jmagman Dec 15, 2023
3c798f9
Fail to see screenshots
jmagman Dec 15, 2023
a706a4d
Revert "Fail to see screenshots"
jmagman Dec 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Revert "Fail to see screenshots" 
This reverts commit a49c3bb.
  • Loading branch information
@jmagman
jmagman committed Dec 19, 2023
commit a706a4d11a4cca2dfa2e597a698b2929f9598f51
2 changes: 1 addition & 1 deletion testing/scenario_app/ios/Scenarios/ScenariosUITests/BogusFontTextTest.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ - (void)testFontRenderingWhenSuppliedWithBogusFont {
[application launch];

XCUIElement* addTextField = application.textFields[@"ready"];
XCTAssertFalse([addTextField waitForExistenceWithTimeout:30]);
XCTAssertTrue([addTextField waitForExistenceWithTimeout:30]);

GoldenTestManager* manager = [[GoldenTestManager alloc] initWithLaunchArg:@"--bogus-font-text"];
[manager checkGoldenForTest:self rmesThreshold:kDefaultRmseThreshold];
Expand Down
2 changes: 1 addition & 1 deletion testing/scenario_app/ios/Scenarios/ScenariosUITests/DarwinSystemFontTests.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ - (void)testFontRendering {
[application launch];

XCUIElement* addTextField = application.textFields[@"ready"];
XCTAssertFalse([addTextField waitForExistenceWithTimeout:30]);
XCTAssertTrue([addTextField waitForExistenceWithTimeout:30]);

GoldenTestManager* manager =
[[GoldenTestManager alloc] initWithLaunchArg:@"--darwin-system-font"];
Expand Down
2 changes: 1 addition & 1 deletion testing/scenario_app/ios/Scenarios/ScenariosUITests/iPadGestureTests.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ - (void)testPointerButtons {

[flutterView tap];
// Initial add event should have buttons = 0
XCTAssertFalse(
XCTAssertTrue(
[app.textFields[@"0,PointerChange.add,device=0,buttons=0"] waitForExistenceWithTimeout:1],
@"PointerChange.add event did not occur for a normal tap");
// Normal tap should have buttons = 0, the flutter framework will ensure it has buttons = 1
Expand Down