Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[Impeller] new blur: refactored math and fixed expanded padding size #49206

Merged
gaaclarke merged 15 commits into from
Dec 20, 2023
Merged

[Impeller] new blur: refactored math and fixed expanded padding size #49206

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
f3d1bf5
[Impeller] made blur subpasses as big as the hint
gaaclarke Dec 18, 2023
f201e5c
++
gaaclarke Dec 18, 2023
7c6e658
++
gaaclarke Dec 18, 2023
9429eb6
++
gaaclarke Dec 18, 2023
9acb2cd
++
gaaclarke Dec 18, 2023
597879e
flipped the branch
gaaclarke Dec 19, 2023
af9c37c
removed downsample size hack
gaaclarke Dec 19, 2023
e7efc25
updated docstring
gaaclarke Dec 19, 2023
9177933
fixed linter
gaaclarke Dec 19, 2023
c855424
updated todo
gaaclarke Dec 19, 2023
f17e00a
fixed tests and turned off hack
gaaclarke Dec 19, 2023
bb87029
added test
gaaclarke Dec 19, 2023
8947a45
Removed the optimization, fixed local padding calculation
gaaclarke Dec 20, 2023
f265eb6
removed rect fix for now
gaaclarke Dec 20, 2023
c799e29
format
gaaclarke Dec 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
removed downsample size hack
  • Loading branch information
@gaaclarke
gaaclarke committed Dec 19, 2023
commit af9c37c8bc8ba747a46e22a234824ece77926ebe
1 change: 0 additions & 1 deletion impeller/entity/contents/filters/gaussian_blur_filter_contents.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,7 +279,6 @@ std::optional<Entity> GaussianBlurFilterContents::RenderFilter(

Scalar desired_scalar =
std::min(CalculateScale(scaled_sigma.x), CalculateScale(scaled_sigma.y));
desired_scalar = 1.0;
// TODO(jonahwilliams): If desired_scalar is 1.0 and we fully acquired the
// gutter from the expanded_coverage_hint, we can skip the downsample pass.
// pass.
Expand Down