Rename to RequestWarmUpFrame and add web time

lib/ui/dart_ui.cc

@@ -98,7 +98,7 @@ typedef CanvasPath Path;
   V(NativeStringAttribute::initSpellOutStringAttribute)            \
   V(PlatformConfigurationNativeApi::DefaultRouteName)              \
   V(PlatformConfigurationNativeApi::ScheduleFrame)                 \
-  V(PlatformConfigurationNativeApi::ForceSyncFrame)                \
+  V(PlatformConfigurationNativeApi::RequestWarmUpFrame)            \
   V(PlatformConfigurationNativeApi::Render)                        \
   V(PlatformConfigurationNativeApi::UpdateSemantics)               \
   V(PlatformConfigurationNativeApi::SetNeedsReportTimings)         \

lib/ui/platform_dispatcher.dart

@@ -801,7 +801,7 @@ class PlatformDispatcher {
   ///
   ///  * [SchedulerBinding], the Flutter framework class which manages the
   ///    scheduling of frames.
-  ///  * [forceSyncFrame], a similar method that is used in rare cases that
+  ///  * [requestWarmUpFrame], a similar method that is used in rare cases that
   ///    a frame must be rendered immediately.
   void scheduleFrame() => _scheduleFrame();
 
@@ -816,7 +816,7 @@ class PlatformDispatcher {
   /// completed synchronously within this call.
   ///
   /// Prefer [scheduleFrame] to update the display in normal operation. The
-  /// [forceSyncFrame] method is designed for situations that require a frame is
+  /// [requestWarmUpFrame] method is designed for situations that require a frame is
   /// rendered as soon as possible, even at the cost of rendering quality. An
   /// example of using this method is [SchedulerBinding.scheduleWarmUpFrame],
   /// which is called during application startup so that the first frame can be
@@ -826,10 +826,10 @@ class PlatformDispatcher {
   ///
   ///  * [SchedulerBinding.scheduleWarmUpFrame], which uses this method.
   ///  * [scheduleFrame].
-  void forceSyncFrame() => _forceSyncFrame();
+  void requestWarmUpFrame() => _requestWarmUpFrame();
 
-  @Native<Void Function()>(symbol: 'PlatformConfigurationNativeApi::ForceSyncFrame')
-  external static void _forceSyncFrame();
+  @Native<Void Function()>(symbol: 'PlatformConfigurationNativeApi::RequestWarmUpFrame')
+  external static void _requestWarmUpFrame();
 
   /// Additional accessibility features that may be enabled by the platform.
   AccessibilityFeatures get accessibilityFeatures => _configuration.accessibilityFeatures;

lib/ui/window/platform_configuration.cc

@@ -589,9 +589,12 @@ void PlatformConfigurationNativeApi::ScheduleFrame() {
   UIDartState::Current()->platform_configuration()->client()->ScheduleFrame();
 }
 
-void PlatformConfigurationNativeApi::ForceSyncFrame() {
+void PlatformConfigurationNativeApi::RequestWarmUpFrame() {
   UIDartState::ThrowIfUIOperationsProhibited();
-  UIDartState::Current()->platform_configuration()->client()->ForceSyncFrame();
+  UIDartState::Current()
+      ->platform_configuration()
+      ->client()
+      ->RequestWarmUpFrame();
 }
 
 void PlatformConfigurationNativeApi::UpdateSemantics(SemanticsUpdate* update) {

lib/ui/window/platform_configuration.h

@@ -68,7 +68,7 @@ class PlatformConfigurationClient {
   //--------------------------------------------------------------------------
   /// @brief
   ///
-  virtual void ForceSyncFrame() = 0;
+  virtual void RequestWarmUpFrame() = 0;
 
   //--------------------------------------------------------------------------
   /// @brief      Updates the client's rendering on the GPU with the newly
@@ -562,7 +562,7 @@ class PlatformConfigurationNativeApi {
 
   static void ScheduleFrame();
 
-  static void ForceSyncFrame();
+  static void RequestWarmUpFrame();
 
   static void Render(int64_t view_id,
                      Scene* scene,

lib/web_ui/lib/platform_dispatcher.dart

@@ -90,7 +90,7 @@ abstract class PlatformDispatcher {
 
   void scheduleFrame();
 
-  void forceSyncFrame();
+  void requestWarmUpFrame();
 
   Future<void> render(Scene scene, [FlutterView view]);
 

lib/web_ui/lib/src/engine/initialization.dart

@@ -102,7 +102,7 @@ void debugResetEngineInitializationState() {
   _initializationState = DebugEngineInitializationState.uninitialized;
 }
 
-void renderFrame(int timeInMicroseconds) {
+void renderFrame(int timeMicroseconds) {
   frameTimingsOnVsync();
 
   // In Flutter terminology "building a frame" consists of "beginning
@@ -114,7 +114,7 @@ void renderFrame(int timeInMicroseconds) {
   frameTimingsOnBuildStart();
   if (EnginePlatformDispatcher.instance.onBeginFrame != null) {
     EnginePlatformDispatcher.instance.invokeOnBeginFrame(
-        Duration(microseconds: timeInMicroseconds));
+        Duration(microseconds: timeMicroseconds));
   }
 
   if (EnginePlatformDispatcher.instance.onDrawFrame != null) {
@@ -196,9 +196,9 @@ Future<void> initializeEngineServices({
       });
     }
   };
-  warmUpFrameCallback = () {
-    // TODO(dkwingsmt): Can we give it some time value?
-    renderFrame(0);
+  requestWarmUpFrameCallback = () {
+    final int timeMicroseconds = (1000 * domWindow.performance.now()).toInt();
+    renderFrame(timeMicroseconds);
   };
 
   assetManager ??= ui_web.AssetManager(assetBase: configuration.assetBase);

lib/web_ui/lib/src/engine/platform_dispatcher.dart

@@ -22,7 +22,7 @@ ui.VoidCallback? scheduleFrameCallback;
 /// Since this will probably call [PlatformWindow.render] outside of an
 /// animation frame, the render will not be actually presented, but just to warm
 /// up the framework.
-ui.VoidCallback? warmUpFrameCallback;
+ui.VoidCallback? requestWarmUpFrameCallback;
 
 /// Signature of functions added as a listener to high contrast changes
 typedef HighContrastListener = void Function(bool enabled);
@@ -779,11 +779,11 @@ class EnginePlatformDispatcher extends ui.PlatformDispatcher {
   }
 
   @override
-  void forceSyncFrame() {
-    if (warmUpFrameCallback == null) {
-      throw Exception('warmUpFrameCallback must be initialized first.');
+  void requestWarmUpFrame() {
+    if (requestWarmUpFrameCallback == null) {
+      throw Exception('requestWarmUpFrameCallback must be initialized first.');
     }
-    warmUpFrameCallback!();
+    requestWarmUpFrameCallback!();
   }
 
   /// Updates the application's rendering on the GPU with the newly provided

runtime/runtime_controller.cc

@@ -341,8 +341,8 @@ void RuntimeController::ScheduleFrame() {
 }
 
 // |PlatformConfigurationClient|
-void RuntimeController::ForceSyncFrame() {
-  client_.ForceSyncFrame();
+void RuntimeController::RequestWarmUpFrame() {
+  client_.RequestWarmUpFrame();
 }
 
 // |PlatformConfigurationClient|

runtime/runtime_controller.h

@@ -658,7 +658,7 @@ class RuntimeController : public PlatformConfigurationClient {
   void ScheduleFrame() override;
 
   // |PlatformConfigurationClient|
-  void ForceSyncFrame() override;
+  void RequestWarmUpFrame() override;
 
   // |PlatformConfigurationClient|
   void Render(Scene* scene, double width, double height) override;

runtime/runtime_delegate.h

@@ -25,7 +25,7 @@ class RuntimeDelegate {
 
   virtual void ScheduleFrame(bool regenerate_layer_trees = true) = 0;
 
-  virtual void ForceSyncFrame() = 0;
+  virtual void RequestWarmUpFrame() = 0;
 
   virtual void Render(std::unique_ptr<flutter::LayerTree> layer_tree,
                       float device_pixel_ratio) = 0;

shell/common/animator.cc

@@ -264,7 +264,7 @@ void Animator::AwaitVSync() {
   }
 }
 
-void Animator::ForceSyncFrame() {
+void Animator::RequestWarmUpFrame() {
   TRACE_EVENT_ASYNC_BEGIN0("flutter", "Forced Frame Request Pending",
                            frame_request_number_);
   regenerate_layer_trees_ = true;

shell/common/animator.h

@@ -53,7 +53,7 @@ class Animator final {
 
   void RequestFrame(bool regenerate_layer_trees = true);
 
-  void ForceSyncFrame();
+  void RequestWarmUpFrame();
 
   //--------------------------------------------------------------------------
   /// @brief    Tells the Animator that this frame needs to render another view.

shell/common/engine.cc

@@ -462,8 +462,8 @@ void Engine::ScheduleFrame(bool regenerate_layer_trees) {
   animator_->RequestFrame(regenerate_layer_trees);
 }
 
-void Engine::ForceSyncFrame() {
-  animator_->ForceSyncFrame();
+void Engine::RequestWarmUpFrame() {
+  animator_->RequestWarmUpFrame();
 }
 
 void Engine::Render(std::unique_ptr<flutter::LayerTree> layer_tree,

shell/common/engine.h

@@ -838,7 +838,7 @@ class Engine final : public RuntimeDelegate, PointerDataDispatcher::Delegate {
   void ScheduleFrame() { ScheduleFrame(true); }
 
   // |RuntimeDelegate|
-  void ForceSyncFrame() override;
+  void RequestWarmUpFrame() override;
 
   // |RuntimeDelegate|
   FontCollection& GetFontCollection() override;

shell/common/engine_unittests.cc

@@ -63,7 +63,7 @@ class MockRuntimeDelegate : public RuntimeDelegate {
  public:
   MOCK_METHOD(std::string, DefaultRouteName, (), (override));
   MOCK_METHOD(void, ScheduleFrame, (bool), (override));
-  MOCK_METHOD(void, ForceSyncFrame, (), (override));
+  MOCK_METHOD(void, RequestWarmUpFrame, (), (override));
   MOCK_METHOD(void,
               Render,
               (std::unique_ptr<flutter::LayerTree>, float),