Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[Impeller] applied the lerp hack to blur (roughly 2x speedup?) #50790

Merged
auto-submit merged 7 commits into from
Feb 21, 2024
Merged

[Impeller] applied the lerp hack to blur (roughly 2x speedup?) #50790

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
8168690
[Impeller] applied the lerp hack to blur (roughly 2x speedup?)
gaaclarke Feb 20, 2024
13b2a31
updated docstring
gaaclarke Feb 20, 2024
ea0e72c
wrote up another test that shows quite a bit of rounding off error
gaaclarke Feb 20, 2024
a658655
fixed math
gaaclarke Feb 20, 2024
f3e23d2
removed old stuff that isn't needed anymore
gaaclarke Feb 21, 2024
13d2f95
tidy
gaaclarke Feb 21, 2024
7527b88
tidy
gaaclarke Feb 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
removed old stuff that isn't needed anymore
  • Loading branch information
@gaaclarke
gaaclarke committed Feb 21, 2024
commit f3e23d2a50d3cf343a40b64eedc8eab28a99a7e2
9 changes: 0 additions & 9 deletions impeller/entity/contents/filters/gaussian_blur_filter_contents.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,6 @@ fml::StatusOr<RenderTarget> MakeDownsampleSubpass(
SetTileMode(&linear_sampler_descriptor, renderer, tile_mode);
linear_sampler_descriptor.mag_filter = MinMagFilter::kLinear;
linear_sampler_descriptor.min_filter = MinMagFilter::kLinear;
linear_sampler_descriptor.mip_filter = MipFilter::kLinear;
TextureFillVertexShader::BindFrameInfo(
pass, host_buffer.EmplaceUniform(frame_info));
TextureFillFragmentShader::BindTextureSampler(
Expand Down Expand Up @@ -168,7 +167,6 @@ fml::StatusOr<RenderTarget> MakeBlurSubpass(
SamplerDescriptor linear_sampler_descriptor = sampler_descriptor;
linear_sampler_descriptor.mag_filter = MinMagFilter::kLinear;
linear_sampler_descriptor.min_filter = MinMagFilter::kLinear;
linear_sampler_descriptor.mip_filter = MipFilter::kLinear;
GaussianBlurFragmentShader::BindTextureSampler(
pass, input_texture,
renderer.GetContext()->GetSamplerLibrary()->GetSampler(
Expand Down Expand Up @@ -518,7 +516,6 @@ KernelPipeline::FragmentShader::KernelSamples LerpHackKernelSamples(
result.sample_count = ((parameters.sample_count - 1) / 2) + 1;
int32_t middle = result.sample_count / 2;
int32_t j = 0;
Scalar coefficient_tally = 0.0f;
for (int i = 0; i < result.sample_count; i++) {
if (i == middle) {
result.samples[i] = parameters.samples[j++];
Expand All @@ -534,12 +531,6 @@ KernelPipeline::FragmentShader::KernelSamples LerpHackKernelSamples(
};
j += 2;
}
coefficient_tally += result.samples[i].coefficient;
}

// Normalize.
for (int i = 0; i < result.sample_count; i++) {
result.samples[i].coefficient /= coefficient_tally;
}

return result;
Expand Down