rename to NoExceptionPromise

impeller/base/base_unittests.cc

@@ -234,15 +234,15 @@ TEST(ConditionVariableTest, TestsCriticalSectionAfterWait) {
   ASSERT_EQ(sum, kThreadCount);
 }
 
-TEST(BaseTest, PromiseDestructWrapperValue) {
-  PromiseDestructWrapper<int> wrapper;
+TEST(BaseTest, NoExceptionPromiseValue) {
+  NoExceptionPromise<int> wrapper;
   std::future future = wrapper.get_future();
   wrapper.set_value(123);
   ASSERT_EQ(future.get(), 123);
 }
 
-TEST(BaseTest, PromiseDestructWrapperEmpty) {
-  auto wrapper = std::make_shared<PromiseDestructWrapper<int>>();
+TEST(BaseTest, NoExceptionPromiseEmpty) {
+  auto wrapper = std::make_shared<NoExceptionPromise<int>>();
   std::future future = wrapper->get_future();
 
   // Destroy the empty promise with the future still pending. Verify that the

impeller/base/promise.h

@@ -23,11 +23,11 @@ std::future<T> RealizedFuture(T t) {
 // By default the std::promise destructor will complete an empty promise with an
 // exception. This will fail because Flutter is built without exception support.
 template <typename T>
-class PromiseDestructWrapper {
+class NoExceptionPromise {
  public:
-  PromiseDestructWrapper() = default;
+  NoExceptionPromise() = default;
 
-  ~PromiseDestructWrapper() {
+  ~NoExceptionPromise() {
     if (!value_set_) {
       promise_.set_value({});
     }

impeller/renderer/backend/vulkan/pipeline_library_vk.cc

@@ -170,7 +170,7 @@ PipelineFuture<PipelineDescriptor> PipelineLibraryVK::GetPipeline(
   }
 
   auto promise = std::make_shared<
-      PromiseDestructWrapper<std::shared_ptr<Pipeline<PipelineDescriptor>>>>();
+      NoExceptionPromise<std::shared_ptr<Pipeline<PipelineDescriptor>>>>();
   auto pipeline_future =
       PipelineFuture<PipelineDescriptor>{descriptor, promise->get_future()};
   pipelines_[descriptor] = pipeline_future;