Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Merged
Changes from 1 commit
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
d2e4ccc
Make sure the elements can't be reached by keyboard
tugorez Apr 23, 2024
ea09d6e
Move the focus to the <flutter-view /> instead of blur.
tugorez Apr 23, 2024
edab1dc
Add listener to the subscription (otherwise never gets cleaned up).
tugorez May 10, 2024
8bbc206
Delay the input removal
tugorez May 10, 2024
ed2f851
Prevent default on pointer down on flutter views
tugorez May 10, 2024
78521ec
Format
tugorez May 10, 2024
72d3956
Add a test that checks focus goes from one input to another
tugorez May 10, 2024
7a6c596
Remove the blur listeners
tugorez May 13, 2024
11b7dae
Enable view focus binding
tugorez May 14, 2024
df75938
Disable view focus binding.
tugorez May 14, 2024
edfdacf
Add ios awaits
tugorez May 14, 2024
7daf2a1
Remove safari desktop delay
tugorez May 17, 2024
7e811da
Remove spaces
tugorez May 17, 2024
c23c944
Bring blur handlers back
tugorez May 18, 2024
08ab966
Format
tugorez May 18, 2024
8c99cb4
Add mising blur handler
tugorez May 18, 2024
153eee4
Remove blur events again lol
tugorez May 18, 2024
e8cf8e8
Prevent scroll on focus
tugorez May 18, 2024
5cf50ac
Make the linter happy
tugorez May 20, 2024
6f85439
Disable view focus
tugorez May 20, 2024
e931fbc
Formatting
tugorez May 20, 2024
d70596d
Refactor focus active dom element
tugorez May 20, 2024
e5af604
Enable view focus binding
tugorez May 20, 2024
e54f9ad
Use handleBlur
tugorez Jun 5, 2024
9a194d3
Apply feedback
tugorez Jun 6, 2024
dca6a02
Apply feedback
tugorez Jun 6, 2024
318a2dd
Apply feedback
tugorez Jun 6, 2024
2a6c339
Merge branch 'main' into focus-management-input
ditman Jun 13, 2024
e35705e
Do not attach a blur handler on Safari
ditman Jun 18, 2024
39c5c8d
Makes shiftKey in DomKeyboardEvent nullable.
ditman Jun 18, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add listener to the subscription (otherwise never gets cleaned up).
  • Loading branch information
tugorez committed May 17, 2024
commit edab1dc0b59cb60c8699050561ac2ae4d9ce3adc
12 changes: 4 additions & 8 deletions lib/web_ui/lib/src/engine/text_editing/text_editing.dart
Original file line number Diff line number Diff line change
Expand Up @@ -1378,8 +1378,7 @@ abstract class DefaultTextEditingStrategy with CompositionAwareMixin implements
subscriptions.add(DomSubscription(domDocument, 'selectionchange',
handleChange));

activeDomElement.addEventListener('beforeinput',
createDomEventListener(handleBeforeInput));
subscriptions.add(DomSubscription(activeDomElement, 'beforeinput', handleBeforeInput));

addCompositionEventHandlers(activeDomElement);

Expand Down Expand Up @@ -1692,8 +1691,7 @@ class IOSTextEditingStrategy extends GloballyPositionedTextEditingStrategy {
subscriptions.add(DomSubscription(domDocument, 'selectionchange',
handleChange));

activeDomElement.addEventListener('beforeinput',
createDomEventListener(handleBeforeInput));
subscriptions.add(DomSubscription(activeDomElement, 'beforeinput', handleBeforeInput));

addCompositionEventHandlers(activeDomElement);

Expand Down Expand Up @@ -1845,8 +1843,7 @@ class AndroidTextEditingStrategy extends GloballyPositionedTextEditingStrategy {
DomSubscription(domDocument, 'selectionchange',
handleChange));

activeDomElement.addEventListener('beforeinput',
createDomEventListener(handleBeforeInput));
subscriptions.add(DomSubscription(activeDomElement, 'beforeinput', handleBeforeInput));

addCompositionEventHandlers(activeDomElement);

Expand Down Expand Up @@ -1909,8 +1906,7 @@ class FirefoxTextEditingStrategy extends GloballyPositionedTextEditingStrategy {
DomSubscription(
activeDomElement, 'keydown', maybeSendAction));

activeDomElement.addEventListener('beforeinput',
createDomEventListener(handleBeforeInput));
subscriptions.add(DomSubscription(activeDomElement, 'beforeinput', handleBeforeInput));

addCompositionEventHandlers(activeDomElement);

Expand Down