Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[Impeller] More efficient usage of transient onscreen attachments. #51206

Merged
auto-submit merged 12 commits into from
Mar 8, 2024
Merged

[Impeller] More efficient usage of transient onscreen attachments. #51206

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
d9b46eb
[Impeller] more efficient use of transient onscreen attachments.
Mar 5, 2024
2819e36
[Impeller] more efficient use of transient onscreen attachments.
Mar 5, 2024
c026f94
Merge branch 'onscreen_improvements' of github.com:jonahwilliams/engi…
Mar 5, 2024
1437114
fold in RP caching.
Mar 5, 2024
743899c
update mock vulkan.
Mar 5, 2024
4432aa1
++
Mar 5, 2024
91ae5d0
Merge branch 'main' of github.com:flutter/engine into onscreen_improv…
Mar 6, 2024
634bee0
merge fix.
Mar 6, 2024
0c5743d
++
Mar 6, 2024
5836a6b
Merge branch 'main' of github.com:flutter/engine into onscreen_improv…
Mar 7, 2024
e7b3a1b
matanl review.
Mar 7, 2024
2dd355a
++
Mar 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
++
  • Loading branch information
jonahwilliams committed Mar 7, 2024
commit 2dd355a60e5690f73b707ed6d266f1bba2ed0dab
5 changes: 3 additions & 2 deletions impeller/renderer/backend/vulkan/test/swapchain_unittests.cc
View file
Open in desktop
Copy link
Contributor

@matanlurey matanlurey Mar 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the test directly verify the "primary trick" outlined in the change context (recycling a single MSAA and Depth/Stencil attachment)?

Copy link
Contributor Author

@jonahwilliams jonahwilliams Mar 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does now

Original file line number Diff line number Diff line change
Expand Up @@ -81,8 +81,9 @@ TEST(SwapchainTest, CachesRenderPassOnSwapchainImage) {
auto render_pass = command_buffer->CreateRenderPass(render_target);
render_pass->EncodeCommands();

depth_stencil_textures.push_back(
render_target.GetDepthAttachment()->texture);
auto& depth = render_target.GetDepthAttachment();
depth_stencil_textures.push_back(depth.has_value() ? depth->texture
: nullptr);
msaa_textures.push_back(
render_target.GetColorAttachments().find(0u)->second.texture);
}
Expand Down