Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[web] Avoid using js_util.{jsify,dartify}() in dart2wasm for converting to JS wrappers #51375

Merged
mkustermann merged 7 commits into from
Mar 18, 2024
Merged

[web] Avoid using js_util.{jsify,dartify}() in dart2wasm for converting to JS wrappers #51375

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
58afe07
[web] Avoid using `js_util.{jsify,dartify}()` in dart2wasm for conver…
mkustermann Mar 13, 2024
e698a6d
address lints & fix test
mkustermann Mar 14, 2024
ddb4682
Revert 41e9b4f8e8e21204807ee1281cfd29ca28551c2f
mkustermann Mar 14, 2024
32458ca
update licenses
mkustermann Mar 14, 2024
702929d
update one more place
mkustermann Mar 14, 2024
097e63e
Keep old toJSAnyShallow/toObjectShallow, make new toJSWrapper/fromJSW…
mkustermann Mar 18, 2024
525432b
hand-format import line
mkustermann Mar 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update one more place
  • Loading branch information
@mkustermann
mkustermann committed Mar 18, 2024
commit 702929d26cd8370127acb03fcf6ef0ee1c57439e
2 changes: 1 addition & 1 deletion lib/web_ui/lib/src/engine/skwasm/skwasm_impl/memory.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ typedef DisposeFunction<T extends NativeType> = void Function(Pointer<T>);

class SkwasmFinalizationRegistry<T extends NativeType> {
SkwasmFinalizationRegistry(this.dispose)
: registry = createDomFinalizationRegistry(((JSNumber address) =>
: registry = DomFinalizationRegistry(((JSNumber address) =>
dispose(Pointer<T>.fromAddress(address.toDartDouble.toInt()))
).toJS);

Expand Down