Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Add more explicit logging (just to stderr) if a try-job detects an untriaged image #51454

Merged
auto-submit merged 3 commits into from
Mar 15, 2024
Merged

Add more explicit logging (just to stderr) if a try-job detects an untriaged image #51454

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1c62298
Write more non-fatal logs to stderr during pre-submit addImg.
matanlurey Mar 15, 2024
10d0fdd
++
matanlurey Mar 15, 2024
a0251d5
++
matanlurey Mar 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
++
  • Loading branch information
@matanlurey
matanlurey committed Mar 15, 2024
commit a0251d5c4c100df29418b92d6b2614e0348f0f30
1 change: 1 addition & 0 deletions testing/skia_gold_client/lib/skia_gold_client.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -423,6 +423,7 @@ interface class SkiaGoldClient {
}
// ... but we want to know about them anyway.
// See https://github.com/flutter/flutter/issues/145219.
// TODO(matanlurey): Update the documentation to reflect the new behavior.
if (isUntriaged) {
_stderr
..writeln('NOTE: Untriaged image detected in tryjob.')
Expand Down