Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

A native Android unit-testing harness. #51479

Merged
auto-submit merged 7 commits into from
Mar 18, 2024
Merged

A native Android unit-testing harness. #51479

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
85ad017
A native Android unit-testing harness.
chinmaygarde Mar 15, 2024
a0a5597
Format.
chinmaygarde Mar 17, 2024
7444097
Lints.
chinmaygarde Mar 17, 2024
40b391b
Fix intermediate names.
chinmaygarde Mar 18, 2024
88d10b6
Docs.
chinmaygarde Mar 18, 2024
dd85af2
Jasons comments.
chinmaygarde Mar 18, 2024
41aa0ff
Derp.
chinmaygarde Mar 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Derp.
  • Loading branch information
@chinmaygarde
chinmaygarde committed Mar 18, 2024
commit 41aa0ff8ae5afc1717d01aa422abd61af823368a
1 change: 1 addition & 0 deletions testing/android/native_activity/native_activity.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ NativeActivity::NativeActivity(ANativeActivity* activity)
FML_CHECK(copied != nullptr)
<< "Allocation failure while saving instance state.";
memcpy(copied, mapping->GetMapping(), mapping->GetSize());
*out_size = mapping->GetSize();
return copied;
Copy link
Member

@jason-simmons jason-simmons Mar 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also set *out_size to mapping->GetSize()

Copy link
Member Author

@chinmaygarde chinmaygarde Mar 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

};
activity->callbacks->onWindowFocusChanged = [](ANativeActivity* activity,
Expand Down