Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[Impeller] Use the scissor to limit all draws by clip coverage. #51698

Merged
auto-submit merged 5 commits into from
Mar 27, 2024
Merged

[Impeller] Use the scissor to limit all draws by clip coverage. #51698

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f527288
[Impeller] Use the scissor to limit all draws by clip coverage.
bdero Mar 27, 2024
c8bce52
Only update the scissor when the clip stack changes.
bdero Mar 27, 2024
2c3b97f
disable optional check
bdero Mar 27, 2024
a59a706
Limit the scissor to the pass size.
bdero Mar 27, 2024
64ae64d
Jonah review
bdero Mar 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
disable optional check
  • Loading branch information
@bdero
bdero committed Mar 27, 2024
commit 2c3b97f38282855506948496e6ae00902c1c25dc
2 changes: 2 additions & 0 deletions impeller/entity/entity_pass_unittests.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,12 @@ TEST(EntityPassClipStackTest, CanPushAndPopEntities) {
EXPECT_EQ(recorder.GetReplayEntities().size(), 2u);
ASSERT_TRUE(recorder.GetReplayEntities()[0].clip_coverage.has_value());
ASSERT_TRUE(recorder.GetReplayEntities()[1].clip_coverage.has_value());
// NOLINTBEGIN(bugprone-unchecked-optional-access)
EXPECT_EQ(recorder.GetReplayEntities()[0].clip_coverage.value(),
Rect::MakeLTRB(0, 0, 100, 100));
EXPECT_EQ(recorder.GetReplayEntities()[1].clip_coverage.value(),
Rect::MakeLTRB(0, 0, 50, 50));
// NOLINTEND(bugprone-unchecked-optional-access)

recorder.RecordEntity(entity, Contents::ClipCoverage::Type::kRestore, Rect());
EXPECT_EQ(recorder.GetReplayEntities().size(), 1u);
Expand Down