This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[et] Resolve dart_executable as an executable #52250
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sets BuildTarget.executable to the `root_out_dir`-relative path of the executable (e.g. `displaylist_unittests`) instead of its label (e.g. `//out/host_debug/displaylist_unittests`). This is required since, in the lines following the output lookup, we assume it to be a path relative to the build output directory. Also breaks out functions for: * `_gnDesc`: returns the JSON output of `gn desc buildDir target` * `_gnOutputs`: returns the output files listed by `gn outputs buildDir target` Noticed while working on: flutter/flutter#147071
Adds a dart_executable rule that compiles Dart code to an ELF, Mach-O, or PE binary. Can be used to build tools written in Dart, or Dart unit tests. Issue: flutter/flutter#147013
Resolves dart_executable targets, which are `action`s with metadata specifying `action_type = [ "dart_executable" ]` to `BuildTargetType.executable`.
Member
|
(triage): I spoke to @cbracken and this is still on his radar. It needs some small tweaks to land. |
Contributor
(PR triage): Hey @cbracken is this still the case? :) |
Member
Author
|
Yep! @matanlurey picked up my other one, which I've now closed. Once his patches land, I'll rebase this and land it. |
Member
Author
|
This was resolved by patches from @matanlurey. Closing as obsolete. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves
dart_executabletargets, which areactions with metadata specifyingaction_type = [ "dart_executable" ]toBuildTargetType.executableinfindTargets.Fixes: flutter/flutter#147071
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.