Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
++
  • Loading branch information
jonahwilliams committed Apr 19, 2024
commit d97e84b57c960f1f298149feb0091bd2baacc6be
9 changes: 6 additions & 3 deletions impeller/entity/contents/vertices_contents.cc
Original file line number Diff line number Diff line change
Expand Up @@ -133,8 +133,8 @@ void VerticesUVContents::SetAlpha(Scalar alpha) {
bool VerticesUVContents::Render(const ContentContext& renderer,
const Entity& entity,
RenderPass& pass) const {
using VS = TexturePipeline::VertexShader;
using FS = TexturePipeline::FragmentShader;
using VS = TiledTexturePipeline::VertexShader;
using FS = TiledTexturePipeline::FragmentShader;

auto src_contents = parent_.GetSourceContents();

Expand All @@ -161,17 +161,20 @@ bool VerticesUVContents::Render(const ContentContext& renderer,
auto geometry_result = geometry->GetPositionBuffer(renderer, entity, pass);
auto opts = OptionsFromPassAndEntity(pass, entity);
opts.primitive_type = geometry_result.type;
pass.SetPipeline(renderer.GetTexturePipeline(opts));
pass.SetPipeline(renderer.GetTiledTexturePipeline(opts));
pass.SetVertexBuffer(std::move(geometry_result.vertex_buffer));

VS::FrameInfo frame_info;
frame_info.mvp = geometry_result.transform;
frame_info.texture_sampler_y_coord_scale =
snapshot->texture->GetYCoordScale();
frame_info.uv_transform = coverage.value().GetNormalizingTransform();
VS::BindFrameInfo(pass, host_buffer.EmplaceUniform(frame_info));

FS::FragInfo frag_info;
frag_info.alpha = alpha_ * snapshot->opacity;
frag_info.x_tile_mode = 0;
frag_info.y_tile_mode = 0;
FS::BindFragInfo(pass, host_buffer.EmplaceUniform(frag_info));
FS::BindTextureSampler(pass, snapshot->texture,
renderer.GetContext()->GetSamplerLibrary()->GetSampler(
Expand Down
7 changes: 0 additions & 7 deletions impeller/entity/geometry/vertices_geometry.h
Original file line number Diff line number Diff line change
Expand Up @@ -37,13 +37,6 @@ class VerticesGeometry final : public Geometry {
const Entity& entity,
RenderPass& pass) const;

// |Geometry|
// GeometryResult GetPositionUVBuffer(Rect texture_coverage,
// Matrix effect_transform,
// const ContentContext& renderer,
// const Entity& entity,
// RenderPass& pass) const override;

// |Geometry|
GeometryResult GetPositionBuffer(const ContentContext& renderer,
const Entity& entity,
Expand Down