This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Add host_profile_arm64 and host_release_arm64 local engine configurations. #52620
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ions. These are used on macOS hosts during local engine development.
zanderso
approved these changes
May 7, 2024
chinmaygarde
added
the
autosubmit
Member
|
Reason for revert: Builds timing out in post submit. I think we should try relanding this with |
zanderso
added
the
revert
auto-submit
bot
removed
the
revert
auto-submit bot
added a commit
that referenced
this pull request
May 7, 2024
…onfigurations. (#52620)" (#52630) Reverts: #52620 Initiated by: zanderso Reason for reverting: Builds timing out in post submit. I think we should try relanding this with `--no-lto` passed to `gn`. Original PR Author: chinmaygarde Reviewed By: {zanderso} This change reverts the following previous change: These are used on macOS hosts during local engine development.
Member
Author
|
Relanding in #52633 |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 7, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
May 7, 2024
…147943) flutter/engine@42898e0...1fe835b 2024-05-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Add host_profile_arm64 and host_release_arm64 local engine configurations. (#52620)" (flutter/engine#52630) 2024-05-07 [email protected] Move `verbose` to `environment.verbose`, pass to `ninja --verbose` if provided. (flutter/engine#52619) 2024-05-07 [email protected] Add host_profile_arm64 and host_release_arm64 local engine configurations. (flutter/engine#52620) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are used on macOS hosts during local engine development.