Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
++
  • Loading branch information
matanlurey committed May 9, 2024
commit a6e1676b2deac357b639b62ae09ed3b3ba05aab1
12 changes: 6 additions & 6 deletions tools/engine_tool/lib/src/commands/run_command.dart
Original file line number Diff line number Diff line change
Expand Up @@ -158,9 +158,9 @@ See `flutter run --help` for a listing

// First build the host.
int r = await runBuild(
environment,
hostBuild,
extraGnArgs: extraGnArgs,
environment,
hostBuild,
extraGnArgs: extraGnArgs,
enableRbe: useRbe,
);
if (r != 0) {
Expand All @@ -170,9 +170,9 @@ See `flutter run --help` for a listing
// Now build the target if it isn't the same.
if (hostBuild.name != build.name) {
r = await runBuild(
environment,
build,
extraGnArgs: extraGnArgs,
environment,
build,
extraGnArgs: extraGnArgs,
enableRbe: useRbe,
);
if (r != 0) {
Expand Down
4 changes: 2 additions & 2 deletions tools/engine_tool/lib/src/commands/test_command.dart
Original file line number Diff line number Diff line change
Expand Up @@ -98,8 +98,8 @@ et test //flutter/fml:fml_benchmarks # Run a single test target in `//flutter/f
// TODO(johnmccutchan): runBuild manipulates buildTargets and adds some
// targets listed in Build. Fix this.
final int buildExitCode = await runBuild(
environment,
build,
environment,
build,
targets: buildTargets,
enableRbe: useRbe,
);
Expand Down
2 changes: 1 addition & 1 deletion tools/engine_tool/lib/src/environment.dart
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ final class Environment {
/// This is a heuristic based on the presence of certain directories in the
/// engine repo; it is not a guarantee that remote builds will work (due to
/// authentication, network, or other issues).
///
///
/// **Note**: This calls does synchronous I/O.
bool hasRbeConfigInTree() {
final String rbeConfigPath = p.join(
Expand Down