Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
removed stray comments
  • Loading branch information
gaaclarke committed May 16, 2024
commit 62c200a0e15afa3e1d65b4d0304eefffec4c1dd2
3 changes: 0 additions & 3 deletions impeller/entity/contents/filters/filter_contents.h
Original file line number Diff line number Diff line change
Expand Up @@ -192,9 +192,6 @@ class FilterContents : public Contents {
/// is used in this case.
virtual void SetRenderingMode(Entity::RenderingMode rendering_mode);

// virtual const Matrix& GetCoverageHintTransform() const { return Matrix();
// };

private:
/// @brief Internal utility method for |GetLocalCoverage| that computes
/// the output coverage of this filter across the specified inputs,
Expand Down
12 changes: 0 additions & 12 deletions impeller/entity/contents/filters/matrix_filter_contents.cc
Original file line number Diff line number Diff line change
Expand Up @@ -112,18 +112,6 @@ std::optional<Rect> MatrixFilterContents::GetFilterCoverage(
return std::nullopt;
}

// Matrix transform;
// if (rendering_mode_ == Entity::RenderingMode::kSubpass) {
// transform = inputs[0]->GetTransform(entity) * //
// effect_transform * //
// matrix_ * //
// effect_transform.Invert();
// } else {
// transform = entity.GetTransform() * //
// matrix_ * //
// entity.GetTransform().Invert() * //
// inputs[0]->GetTransform(entity);
// }
auto& m = rendering_mode_ == Entity::RenderingMode::kSubpass
? effect_transform
: inputs[0]->GetTransform(entity);
Expand Down