Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Localize Picture ownership
  • Loading branch information
bdero committed May 20, 2024
commit 9ee33eb340dd28f8ef54e5a06e78a7683fbc9003
30 changes: 18 additions & 12 deletions impeller/aiks/aiks_playground.cc
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,20 @@ void AiksPlayground::TearDown() {
}

bool AiksPlayground::OpenPlaygroundHere(Picture picture) {
return OpenPlaygroundHere([&picture](AiksContext& renderer) -> Picture {
return std::move(picture);
});
if (!switches_.enable_playground) {
return true;
}

AiksContext renderer(GetContext(), typographer_context_);

if (!renderer.IsValid()) {
return false;
}

return Playground::OpenPlaygroundHere(
[&renderer, &picture](RenderTarget& render_target) -> bool {
return renderer.Render(picture, render_target, true);
});
}

bool AiksPlayground::OpenPlaygroundHere(AiksPlaygroundCallback callback) {
Expand All @@ -45,18 +56,13 @@ bool AiksPlayground::OpenPlaygroundHere(AiksPlaygroundCallback callback) {
return false;
}

std::optional<Picture> last_frame;

return Playground::OpenPlaygroundHere(
[&renderer, &callback, &last_frame](RenderTarget& render_target) -> bool {
[&renderer, &callback](RenderTarget& render_target) -> bool {
std::optional<Picture> picture = callback(renderer);
if (picture.has_value() && picture->pass != nullptr) {
last_frame = std::move(picture);
}
if (!last_frame.has_value()) {
return false; // The first frame rendered nothing. Fail
if (!picture.has_value()) {
return false;
}
return renderer.Render(*last_frame, render_target, true);
return renderer.Render(*picture, render_target, true);
});
}

Expand Down