Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[Impeller] added a fallback that will make sure the blur fragment shader doesn't overflow #53466

Merged
auto-submit merged 5 commits into from
Jun 24, 2024
Merged

[Impeller] added a fallback that will make sure the blur fragment shader doesn't overflow #53466

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0e1abc9
[Impeller] added a fallback that will make sure the blur fragment sha…
gaaclarke Jun 18, 2024
22107a2
fixed assert
gaaclarke Jun 18, 2024
71aea44
fixes stack overflow
gaaclarke Jun 19, 2024
29b5c0c
cleaned up the overflow fix
gaaclarke Jun 24, 2024
cdf884d
got rid of extra buffer in larger kernel samples
gaaclarke Jun 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixed assert
  • Loading branch information
@gaaclarke
gaaclarke committed Jun 18, 2024
commit 22107a245b396e27e7cf1bd4dd0b21a2c5c454cc
2 changes: 1 addition & 1 deletion impeller/entity/contents/filters/gaussian_blur_filter_contents_unittests.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -624,7 +624,7 @@ TEST(GaussianBlurFilterContentsTest, ChopHugeBlurs) {
.step_size = 1};
GaussianBlurPipeline::FragmentShader::KernelSamples kernel_samples =
GenerateBlurInfo(parameters);
EXPECT_EQ(kernel_samples.sample_count, 50);
EXPECT_EQ(kernel_samples.sample_count, 98);
}

} // namespace testing
Expand Down