Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[Impeller] Re-enable fast blur path for elliptical rrects #53704

Merged
auto-submit merged 3 commits into from
Jul 4, 2024
Merged

[Impeller] Re-enable fast blur path for elliptical rrects #53704

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
af9c825
[Impeller] Re-enable fast blur path for elliptical rrects
flar Jul 2, 2024
0139868
test fixes
flar Jul 3, 2024
4839f13
print out test values on error
flar Jul 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
print out test values on error
  • Loading branch information
@flar
flar committed Jul 3, 2024
commit 4839f13be4f5bc1372e23c26fc154b96e4b92a23
6 changes: 4 additions & 2 deletions impeller/display_list/skia_conversions_unittests.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,10 +201,12 @@ TEST(SkiaConversionsTest, IsNearlySimpleRRect) {
auto save = test.values[i];
test.values[i] -= kEhCloseEnough * 0.5f;
rrect.setRectRadii(rect, test.radii);
EXPECT_TRUE(skia_conversions::IsNearlySimpleRRect(rrect));
EXPECT_TRUE(skia_conversions::IsNearlySimpleRRect(rrect))
<< "values[" << i << "] == " << test.values[i];
test.values[i] -= kEhCloseEnough * 2.0f;
rrect.setRectRadii(rect, test.radii);
EXPECT_FALSE(skia_conversions::IsNearlySimpleRRect(rrect));
EXPECT_FALSE(skia_conversions::IsNearlySimpleRRect(rrect))
<< "values[" << i << "] == " << test.values[i];
test.values[i] = save;
}
}
Expand Down