Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Redirect run_ios_tests.sh to run_ios_tests.dart. #53717

Merged
auto-submit merged 11 commits into from
Sep 10, 2024
Merged

Redirect run_ios_tests.sh to run_ios_tests.dart. #53717

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
401c5ff
Redirect run_ios_tests.sh to run_ios_tests.dart.
matanlurey Jul 3, 2024
3e3816b
Delete bundle between runs
jmagman Jul 10, 2024
efb54b5
++
matanlurey Jul 11, 2024
eccb6db
++
matanlurey Jul 11, 2024
26f61d1
++
matanlurey Jul 11, 2024
d6f2d36
++
matanlurey Jul 31, 2024
ab8b35f
++
matanlurey Aug 1, 2024
3a9683c
Fix quotes
jmagman Sep 9, 2024
b09eab5
Merge remote-tracking branch 'upstream/main' into run-ios-tests-dart-…
matanlurey Sep 10, 2024
df1255e
Move resultBundle.delete into the if block.
matanlurey Sep 10, 2024
0078d9b
Conditonally delete.
matanlurey Sep 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
++
  • Loading branch information
@matanlurey @jmagman
matanlurey authored and jmagman committed Sep 9, 2024
commit efb54b56faaf38d9a036efaa5be71609d82c79da
5 changes: 3 additions & 2 deletions testing/scenario_app/bin/run_ios_tests.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,9 @@ void main(List<String> args) async {
if (results.option('dump-xcresult-on-failure') case final String path) {
dumpXcresultOnFailurePath = path;
} else {
dumpXcresultOnFailurePath = io.Directory.systemTemp.createTempSync().path;
final dumpDir = io.Directory.systemTemp.createTempSync();
dumpXcresultOnFailurePath = dumpDir.path;
cleanup.add(() => dumpDir.delete(recursive: true));
Copy link
Member

@jmagman jmagman Jul 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matanlurey it needs to be deleted between the Skia and Impeller run though, not at the end of running both.

Copy link
Contributor Author

@matanlurey matanlurey Jul 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes, you are right. Thank you!

}

// Run the actual script.
Expand Down Expand Up @@ -369,6 +371,5 @@ String _zipAndStoreFailedTestResults({
if (result.exitCode != 0) {
throw Exception('Failed to zip the test results: ${result.stderr}');
}
resultBundle.deleteSync(recursive: true);
return outputPath;
}