-
Notifications
You must be signed in to change notification settings - Fork 6k
[iOS] Supported rendering platform views without merging the raster thread. #53826
Changes from 1 commit
02556ae
b3f6670
b31aae6
75f931a
4525bd8
6ce3aa0
be03cf8
6770376
912cd40
1f65cc3
53adc81
870b950
f8267bd
80565d5
2b9a825
0a7dc5a
2745e88
6002aa0
e7a832f
f099d74
e2e6a2a
44d5b5b
b53063a
9a84539
65a5210
735ce22
a4f523b
b6c3345
a4b771e
cd8e1de
6603d18
27c0daa
d794211
2f4314b
25a4e06
ea2e66d
d220885
9b534cd
970e13a
63ebe66
ff4802a
e3fc731
c0fab3b
d73671e
7285907
bcd8519
b25a742
5f6a8d4
be7853d
b19b4d8
ab08739
6e6e5a2
355ab30
8cd1c74
30e7b97
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
- Loading branch information
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -635,20 +635,20 @@ static bool ClipRRectContainsPlatformViewBoundingRect(const SkRRect& clip_rrect, | |
| } | ||
|
|
||
| void FlutterPlatformViewsController::Reset() { | ||
| composition_order_.clear(); | ||
| slices_.clear(); | ||
| current_composition_params_.clear(); | ||
| views_to_recomposite_.clear(); | ||
| layer_pool_->RecycleLayers(); | ||
| visited_platform_views_.clear(); | ||
|
|
||
| fml::TaskRunner::RunNowOrPostTask( | ||
| platform_task_runner_, [&, composition_order = composition_order_]() { | ||
| for (int64_t view_id : composition_order_) { | ||
| [platform_views_[view_id].root_view.get() removeFromSuperview]; | ||
| } | ||
| platform_views_.clear(); | ||
| }); | ||
|
|
||
| composition_order_.clear(); | ||
| slices_.clear(); | ||
| current_composition_params_.clear(); | ||
| views_to_recomposite_.clear(); | ||
| layer_pool_->RecycleLayers(); | ||
| visited_platform_views_.clear(); | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Are these variables ever mutated on main thread as well? Or only on raster thread?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Only on the raster thread
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Gotcha. Are all of the embedder callback APIs (e.g.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks! I think it's indeed a simpler (and better) design |
||
| } | ||
|
|
||
| bool FlutterPlatformViewsController::SubmitFrame(GrDirectContext* gr_context, | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.