Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Merged
Changes from 1 commit
Commits
Show all changes
38 commits
Select commit Hold shift + click to select a range
9d59af1
[Impeller] separate algorithm for computing render target size.
Aug 18, 2024
a935594
++
Aug 18, 2024
7aa3a48
Update save_layer_utils_unittests.cc
Aug 18, 2024
54cea5a
nolint.
Aug 19, 2024
e6e56d8
oh boy here we go.
Aug 19, 2024
98a5d68
cleanups.
Aug 19, 2024
81ccaa0
remove print.
Aug 19, 2024
55a6a50
Update save_layer_utils_unittests.cc
Aug 19, 2024
3591395
dont overwrite save layer bounds.
Aug 19, 2024
a8f0e2c
Merge branch 'render_target_sizing' of github.com:jonahwilliams/engin…
Aug 19, 2024
1c55cf5
++
Aug 20, 2024
a6f5f21
Update dl_dispatcher.cc
Aug 20, 2024
a646c1b
++
Aug 20, 2024
8daf291
Merge branch 'main' of github.com:flutter/engine into render_target_s…
Aug 20, 2024
199a846
++
Aug 20, 2024
b2eb6b9
++
Aug 20, 2024
d347783
++
Aug 20, 2024
24442e0
flood clip.
Aug 21, 2024
78b7f60
add flood clip.
Aug 21, 2024
2a4ac2d
++
Aug 21, 2024
3eff88b
++
Aug 21, 2024
04b5be5
Update entity_pass.cc
Aug 21, 2024
086abb8
Update entity_pass.h
Aug 21, 2024
4a5f30b
++
Aug 21, 2024
fa3afcc
Merge branch 'render_target_sizing' of github.com:jonahwilliams/engin…
Aug 21, 2024
4e7a707
partial review feedback.
Aug 23, 2024
e0105d7
more adjustments.
Aug 23, 2024
e8f34ac
oops
Aug 23, 2024
8a3d1ef
Merge branch 'main' into render_target_sizing
Aug 27, 2024
24ef59a
Merge branch 'main' into render_target_sizing
Aug 28, 2024
0cae7a8
flar review.
Aug 29, 2024
ae57e62
Merge branch 'main' of github.com:flutter/engine into render_target_s…
Aug 29, 2024
bc2276e
no bds from caller.
Aug 30, 2024
b3ab833
update comment.
Aug 30, 2024
334e5e9
++
Aug 30, 2024
82a6621
++
Aug 30, 2024
5011b3c
++
Aug 30, 2024
008b6f9
++
Aug 30, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update save_layer_utils_unittests.cc
  • Loading branch information
Jonah Williams authored Aug 19, 2024
commit 55a6a501e76c935eb8e9a0f392a7f5e55e710e9b
26 changes: 13 additions & 13 deletions impeller/entity/save_layer_utils_unittests.cc
Original file line number Diff line number Diff line change
Expand Up @@ -134,19 +134,19 @@ TEST(SaveLayerUtilsTest, DisjointCoverageTransformedByImageFilter) {
EXPECT_EQ(coverage.value(), Rect::MakeLTRB(200, 200, 210, 210));
}

TEST(SaveLayerUtilsTest, DisjointCoverageNotTransformedByCTM) {
// Coverage disjoint from parent coverage. CTM does not impact lack of
// intersection as it has already been "absorbed" by child coverage.
Matrix ctm = Matrix::MakeTranslation({-200, -200, 0});
auto coverage = ComputeSaveLayerCoverage(
/*content_coverage=*/Rect::MakeLTRB(200, 200, 210, 210), //
/*effect_transform=*/ctm, //
/*coverage_limit=*/Rect::MakeLTRB(0, 0, 100, 100), //
/*image_filter=*/nullptr //
);

ASSERT_FALSE(coverage.has_value());
}
// TEST(SaveLayerUtilsTest, DisjointCoverageNotTransformedByCTM) {
// // Coverage disjoint from parent coverage. CTM does not impact lack of
// // intersection as it has already been "absorbed" by child coverage.
// Matrix ctm = Matrix::MakeTranslation({-200, -200, 0});
// auto coverage = ComputeSaveLayerCoverage(
// /*content_coverage=*/Rect::MakeLTRB(200, 200, 210, 210), //
// /*effect_transform=*/ctm, //
// /*coverage_limit=*/Rect::MakeLTRB(0, 0, 100, 100), //
// /*image_filter=*/nullptr //
// );

// ASSERT_FALSE(coverage.has_value());
// }

TEST(SaveLayerUtilsTest, BasicEmptyCoverage) {
auto coverage = ComputeSaveLayerCoverage(
Expand Down