Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Delay the window until the first frame is received from the Flutter engine #54703

Merged
robert-ancell merged 18 commits into from
Sep 16, 2024
Merged

Delay the window until the first frame is received from the Flutter engine #54703

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
280cc52
Move the FlApplication from the template into the linux embedder.
robert-ancell Feb 22, 2024
8376a68
Update license
robert-ancell Aug 20, 2024
34c05aa
Fix code style for signal enum
robert-ancell Aug 20, 2024
457bf8c
Add a test
robert-ancell Aug 20, 2024
49d05c6
Remove mock file
robert-ancell Aug 20, 2024
66aafb8
Fix ordering of includes
robert-ancell Aug 21, 2024
b5a01d7
Merge remote-tracking branch 'origin/main' into linux-application
robert-ancell Aug 22, 2024
d965fb7
Delay the window until the first frame is received from the Flutter e…
robert-ancell Aug 22, 2024
66c3c9f
Update shell/platform/linux/public/flutter_linux/fl_application.h
robert-ancell Aug 22, 2024
87dd216
Merge remote-tracking branch 'origin/main' into linux-application
robert-ancell Aug 29, 2024
1e4e814
Merge branch 'linux-application' into linux-delay-window
robert-ancell Aug 29, 2024
e7d5adc
Merge remote-tracking branch 'origin/main' into linux-application
robert-ancell Sep 3, 2024
ef9c4c5
Remove default window properties and use the create-window signal for…
robert-ancell Sep 3, 2024
f5861be
Merge branch 'linux-application' into linux-delay-window
robert-ancell Sep 3, 2024
919fc29
Merge remote-tracking branch 'origin/main' into linux-delay-window
robert-ancell Sep 3, 2024
8715fa1
Merge branch 'main' into linux-delay-window
robert-ancell Sep 12, 2024
bd847d0
Add a first frame signal view test
robert-ancell Sep 16, 2024
8f3a300
Fix lint failure on CI
robert-ancell Sep 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix code style for signal enum
  • Loading branch information
@robert-ancell
robert-ancell committed Aug 20, 2024
commit 34c05aa6f077c8045276f281277f534b2087b94d
8 changes: 4 additions & 4 deletions shell/platform/linux/fl_application.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,9 @@ struct FlApplicationPrivate {
((FlApplicationPrivate*)fl_application_get_instance_private( \
FL_APPLICATION(app)))

enum { SIGNAL_REGISTER_PLUGINS, NR_SIGNALS };
enum { kSignalRegisterPlugins, kSignalLastSignal };

static guint fl_application_signals[NR_SIGNALS];
static guint fl_application_signals[kSignalLastSignal];

G_DEFINE_TYPE_WITH_CODE(FlApplication,
fl_application,
Expand Down Expand Up @@ -91,7 +91,7 @@ static void fl_application_activate(GApplication* application) {
gtk_widget_show(GTK_WIDGET(view));
gtk_container_add(GTK_CONTAINER(window), GTK_WIDGET(view));

g_signal_emit(self, fl_application_signals[SIGNAL_REGISTER_PLUGINS], 0,
g_signal_emit(self, fl_application_signals[kSignalRegisterPlugins], 0,
FL_PLUGIN_REGISTRY(view));

gtk_widget_grab_focus(GTK_WIDGET(view));
Expand Down Expand Up @@ -141,7 +141,7 @@ static void fl_application_class_init(FlApplicationClass* klass) {

klass->register_plugins = fl_application_register_plugins;

fl_application_signals[SIGNAL_REGISTER_PLUGINS] = g_signal_new(
fl_application_signals[kSignalRegisterPlugins] = g_signal_new(
"register-plugins", fl_application_get_type(), G_SIGNAL_RUN_LAST,
G_STRUCT_OFFSET(FlApplicationClass, register_plugins), NULL, NULL,
g_cclosure_marshal_VOID__OBJECT, G_TYPE_NONE, 1,
Expand Down