Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[engine] reland: always post tasks for platform channel responses. #55006

Merged
auto-submit merged 6 commits into from
Sep 6, 2024
Merged

[engine] reland: always post tasks for platform channel responses. #55006

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f4d4aa7
[engine] always force platform channel responses to schedule a task.
Sep 5, 2024
58ea524
make initial route not confusing as all heck.
Sep 6, 2024
7cfdde5
set initial route.
Sep 6, 2024
d1a3626
add guard and comment.
Sep 6, 2024
4277653
try this.
Sep 6, 2024
ba3ecbe
maybe this works.
Sep 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add guard and comment.
  • Loading branch information
jonahwilliams committed Sep 6, 2024
commit d1a36269f4f01efa9f12c2bd36f94d50cbde89da
11 changes: 8 additions & 3 deletions shell/platform/darwin/ios/framework/Source/FlutterEngine.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -897,9 +897,14 @@ - (BOOL)createShell:(NSString*)entrypoint
_isGpuDisabled =
[UIApplication sharedApplication].applicationState == UIApplicationStateBackground;
#endif
settings.route = [self.initialRoute UTF8String];
[self.initialRoute release];
self.initialRoute = nil;
// Override the setting route, as the dart project or function may have specified
// different values. During construction, the Engine constuctor will read the
// value of settings.route to determine the initial route value.
if (self.initialRoute) {
settings.route = [self.initialRoute UTF8String];
[self.initialRoute release];
self.initialRoute = nil;
}

// Create the shell. This is a blocking operation.
std::unique_ptr<flutter::Shell> shell = flutter::Shell::Create(
Expand Down