Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[Impeller] fix obvious memory leak. #55036

Merged
auto-submit merged 5 commits into from
Sep 9, 2024
Merged

[Impeller] fix obvious memory leak. #55036

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b9e4578
duh.
Sep 9, 2024
2b30573
Update gpu_surface_metal_impeller.mm
Sep 9, 2024
8893568
++
Sep 9, 2024
ad38c6e
Merge branch 'out_of_memory' of github.com:jonahwilliams/engine into …
Sep 9, 2024
27757ae
++
Sep 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
duh.
  • Loading branch information
jonahwilliams committed Sep 9, 2024
commit b9e4578125307c6aeca26d53d079395ff5ec7757
5 changes: 1 addition & 4 deletions shell/gpu/gpu_surface_metal_impeller.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,6 @@

impeller::IRect cull_rect = surface->coverage();
SkIRect sk_cull_rect = SkIRect::MakeWH(cull_rect.GetWidth(), cull_rect.GetHeight());
const bool reset_host_buffer = surface_frame.submit_info().frame_boundary;

impeller::RenderTarget render_target = surface->GetTargetRenderPassDescriptor();
surface->SetFrameBoundary(surface_frame.submit_info().frame_boundary);
Expand All @@ -183,9 +182,7 @@
display_list->Dispatch(impeller_dispatcher, sk_cull_rect);
impeller_dispatcher.FinishRecording();
aiks_context->GetContentContext().GetLazyGlyphAtlas()->ResetTextFrames();
if (reset_host_buffer) {
aiks_context->GetContentContext().GetTransientsBuffer().Reset();
}
aiks_context->GetContentContext().GetTransientsBuffer().Reset();

if (!surface->PreparePresent()) {
return false;
Expand Down