Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
touch up and skip test on html and firefox
  • Loading branch information
harryterkelsen committed Sep 26, 2024
commit 08ca6c3226b9569280affa925d221149501f483d
2 changes: 1 addition & 1 deletion lib/web_ui/lib/src/engine/canvaskit/layer_visitor.dart
Original file line number Diff line number Diff line change
Expand Up @@ -600,7 +600,7 @@ class PaintVisitor extends LayerVisitor {
final List<PictureLayer>? pictureChildren =
picturesUnderShaderMask[shaderMask];
if (pictureChildren != null) {
for (final PictureLayer picture in pictureChildren!) {
for (final PictureLayer picture in pictureChildren) {
canvases.add(viewEmbedder!.getOptimizedCanvasFor(picture));
}
}
Expand Down
4 changes: 3 additions & 1 deletion lib/web_ui/test/ui/scene_builder_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -400,7 +400,9 @@ Future<void> testMain() async {

await matchGoldenFile('scene_builder_shader_mask_clipped_out.png',
region: region);
});
},
skip: isFirefox &&
isHtml); // https://github.com/flutter/flutter/issues/86623
});
}

Expand Down