Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[impeller] enable framebuffer blit when available #56596

Merged
gaaclarke merged 10 commits into from
Nov 18, 2024
Merged

[impeller] enable framebuffer blit when available #56596

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
7b2ac98
Enabled opengles3 blits
gaaclarke Nov 14, 2024
49fd421
flipped the images back
gaaclarke Nov 14, 2024
4b3781a
++
gaaclarke Nov 15, 2024
0f91725
updated test
gaaclarke Nov 15, 2024
2bf0e96
added at golden test
gaaclarke Nov 15, 2024
671c3b5
updated shell test
gaaclarke Nov 15, 2024
bd255e4
fixed tidy
gaaclarke Nov 15, 2024
e84ce6d
registered the test as a golden test
gaaclarke Nov 15, 2024
b6adb29
added testing golden
gaaclarke Nov 15, 2024
d2fb626
oops
gaaclarke Nov 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
updated shell test
  • Loading branch information
@gaaclarke
gaaclarke committed Nov 15, 2024
commit 671c3b54774d8c9df71aa1b7c907b35bc4657e9d
9 changes: 9 additions & 0 deletions shell/platform/android/android_context_gl_impeller_unittests.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,15 @@ TEST_F(AndroidContextGLImpellerTest, FallbackForEmulator) {
EXPECT_CALL(
*display,
ChooseConfig(Matcher<ConfigDescriptor>(AllOf(
Field(&ConfigDescriptor::api, impeller::egl::API::kOpenGLES3),
Copy link
Member Author

@gaaclarke gaaclarke Nov 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jonahwilliams looks like we could have used these tests for asserting we are asking for a depth buffer. It had been a while since I looked at these.

Copy link
Contributor

@jonahwilliams jonahwilliams Nov 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought I did that by adding EGL_DEPTH_SIZE 24 above?

Copy link
Contributor

@jonahwilliams jonahwilliams Nov 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤷‍♂️

Field(&ConfigDescriptor::samples, impeller::egl::Samples::kFour),
Field(&ConfigDescriptor::surface_type,
impeller::egl::SurfaceType::kWindow)))))
.WillOnce(Return(ByMove(std::move(first_result))));
EXPECT_CALL(
*display,
ChooseConfig(Matcher<ConfigDescriptor>(AllOf(
Field(&ConfigDescriptor::api, impeller::egl::API::kOpenGLES2),
Field(&ConfigDescriptor::samples, impeller::egl::Samples::kFour),
Field(&ConfigDescriptor::surface_type,
impeller::egl::SurfaceType::kWindow)))))
Expand Down