Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

EmbedderTest: templatise GetEmbedderContext #56709

Merged
auto-submit merged 2 commits into from
Nov 19, 2024
Merged

EmbedderTest: templatise GetEmbedderContext #56709

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
939c851
EmbedderTest: templatise GetEmbedderContext
cbracken Nov 19, 2024
504a1a3
review: add comment
cbracken Nov 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions shell/platform/embedder/tests/embedder_a11y_unittests.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,8 @@ constexpr static char kTooltip[] = "tooltip";

TEST_F(EmbedderTest, CannotProvideMultipleSemanticsCallbacks) {
{
EmbedderConfigBuilder builder(
GetEmbedderContext(EmbedderTestContextType::kSoftwareContext));
auto& context = GetEmbedderContext<EmbedderTestContextSoftware>();
EmbedderConfigBuilder builder(context);
builder.SetSurface(SkISize::Make(1, 1));
builder.GetProjectArgs().update_semantics_callback =
[](const FlutterSemanticsUpdate* update, void* user_data) {};
Expand All @@ -46,8 +46,8 @@ TEST_F(EmbedderTest, CannotProvideMultipleSemanticsCallbacks) {
}

{
EmbedderConfigBuilder builder(
GetEmbedderContext(EmbedderTestContextType::kSoftwareContext));
auto& context = GetEmbedderContext<EmbedderTestContextSoftware>();
EmbedderConfigBuilder builder(context);
builder.SetSurface(SkISize::Make(1, 1));
builder.GetProjectArgs().update_semantics_callback2 =
[](const FlutterSemanticsUpdate2* update, void* user_data) {};
Expand All @@ -61,8 +61,8 @@ TEST_F(EmbedderTest, CannotProvideMultipleSemanticsCallbacks) {
}

{
EmbedderConfigBuilder builder(
GetEmbedderContext(EmbedderTestContextType::kSoftwareContext));
auto& context = GetEmbedderContext<EmbedderTestContextSoftware>();
EmbedderConfigBuilder builder(context);
builder.SetSurface(SkISize::Make(1, 1));
builder.GetProjectArgs().update_semantics_callback =
[](const FlutterSemanticsUpdate* update, void* user_data) {};
Expand All @@ -76,8 +76,8 @@ TEST_F(EmbedderTest, CannotProvideMultipleSemanticsCallbacks) {
}

{
EmbedderConfigBuilder builder(
GetEmbedderContext(EmbedderTestContextType::kSoftwareContext));
auto& context = GetEmbedderContext<EmbedderTestContextSoftware>();
EmbedderConfigBuilder builder(context);
builder.SetSurface(SkISize::Make(1, 1));
builder.GetProjectArgs().update_semantics_callback2 =
[](const FlutterSemanticsUpdate2* update, void* user_data) {};
Expand All @@ -98,7 +98,7 @@ TEST_F(EmbedderA11yTest, A11yTreeIsConsistentUsingV3Callbacks) {
GTEST_SKIP() << "This test crashes on Fuchsia. https://fxbug.dev/87493 ";
#else

auto& context = GetEmbedderContext(EmbedderTestContextType::kSoftwareContext);
auto& context = GetEmbedderContext<EmbedderTestContextSoftware>();

fml::AutoResetWaitableEvent signal_native_latch;

Expand Down Expand Up @@ -277,7 +277,7 @@ TEST_F(EmbedderA11yTest, A11yStringAttributes) {
GTEST_SKIP() << "This test crashes on Fuchsia. https://fxbug.dev/87493 ";
#else

auto& context = GetEmbedderContext(EmbedderTestContextType::kSoftwareContext);
auto& context = GetEmbedderContext<EmbedderTestContextSoftware>();

fml::AutoResetWaitableEvent signal_native_latch;

Expand Down Expand Up @@ -397,7 +397,7 @@ TEST_F(EmbedderA11yTest, A11yTreeIsConsistentUsingV2Callbacks) {
GTEST_SKIP() << "This test crashes on Fuchsia. https://fxbug.dev/87493 ";
#else

auto& context = GetEmbedderContext(EmbedderTestContextType::kSoftwareContext);
auto& context = GetEmbedderContext<EmbedderTestContextSoftware>();

fml::AutoResetWaitableEvent signal_native_latch;

Expand Down Expand Up @@ -570,7 +570,7 @@ TEST_F(EmbedderA11yTest, A11yTreeIsConsistentUsingV2Callbacks) {
}

TEST_F(EmbedderA11yTest, A11yTreeIsConsistentUsingV1Callbacks) {
auto& context = GetEmbedderContext(EmbedderTestContextType::kSoftwareContext);
auto& context = GetEmbedderContext<EmbedderTestContextSoftware>();

fml::AutoResetWaitableEvent signal_native_latch;

Expand Down
Loading