This repository was archived by the owner on Feb 25, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6k
DO NOT LAND: But I'm really curious to see if anything blows up #56766
Closed
Closed
Changes from 1 commit
Commits
Show all changes
104 commits
Select commit
Hold shift + click to select a range
2da92cb
Migrate PlatformViewsController to Objective-C
cbracken 3f6b2de
Add Obj-C wrapper to engine
cbracken 2416e53
Eliminate wrapper property on engine class
cbracken 8183daa
Use wrapper class on FlutterViewController, FlutterViewEngineDelegate
cbracken 9230301
Update AccessibilityBridge to use wrapper
cbracken 23e03a2
Pass wrapper to PlatformViewIOS
cbracken 9dd337d
Pass wrapped class to IOSExternalViewEmbedder
cbracken 0966e0e
Extract onMethodCall:result:
cbracken 431dda2
Goodbye WeakPtr
cbracken f4c64ad
Format
cbracken fc08ce4
Migrate setTaskRunner
cbracken 2810996
SetTaskRunner
cbracken 8f994c4
Migrate setFlutterView
cbracken ff6fdb5
Migrate [set]viewController
cbracken 0037903
flutterViewContoller
cbracken 5644c4f
registerViewFactory:withId:policy:
cbracken c8703c5
beginFrameWithSize:
cbracken c887bfe
cancelFrame
cbracken aad6664
prerollCompositeEmbeddedView:withParams:
cbracken 1ffcaa6
flutterTouchInterceptingViewForId:
cbracken fd5dc58
postPrerollActionWithThreadMerger:impellerEnabled:
cbracken ba646ae
endFrameWithResubmit:threadMerger:impellerEnabled:
cbracken 283c7fa
compositeEmbeddedViewWithId:
cbracken 23f0a97
reset
cbracken 7967475
submitFrameWithGrContext:iosContext:frame:
cbracken 7576e06
firstResponderPlatformViewId
cbracken bdf629f
pushFilterToVisitedPlatformViews:withRect:
cbracken 303b32d
pushVisitedPlatformViewId:
cbracken f774ca0
embeddedViewCount
cbracken d21753b
platformViewForId:
cbracken 99ddc89
compositeView:withParams:
cbracken 34390e6
compositionParamsForView:
cbracken 18a7851
Remove public instance getter
cbracken e1742bc
Migrate to weak pointers
cbracken aa0e076
Move C++ class to implementation file
cbracken 0c9adc6
Switch to unique_ptr
cbracken b580ed2
Remove unused LayerPoolSize
cbracken f1c7c7d
Extract PlatformViewData
cbracken 48e8a45
Extract LayerData struct
cbracken 1c1c0e1
Migrate FlutterPlatformViewsController.instance to a property
cbracken 0c2dbe0
add taskRunner property
cbracken f1f3c48
Migreate flutterView to property
cbracken 04ac3f6
Migrate flutterViewController to property
cbracken 6a7c27d
Migrate registerViewFactory impl
cbracken 416e118
Migrate beginFrameWithSize: impl
cbracken 8437d7b
Migrate postPrerollActionWithThreadMerger: impl
cbracken 9257a57
Migrate cancelFrame impl
cbracken c363355
Migrate prerollCompositeEmbeddedView: impl
cbracken e8c9750
Migrate platformViewForId: impl
cbracken 7cca9c5
Migrate flutterTouchInterceptingViewForId: impl
cbracken a998d21
Migrate endFrameWithResubmit: impl
cbracken cb1519b
Migrate compositeEmbeddedViewWithId:
cbracken ede12b9
Migrate reset impl
cbracken 15f9764
Migrate submitFrame impl
cbracken 5c8e0b0
Migrate pushFilterToVisitedPlatformViews impl
cbracken 20663d9
Migrate pushVisitedPlatformViewId
cbracken b6e7aea
Migrate embeddedViewCount
cbracken b3ad201
Delete GetCompositionParams
cbracken 6eb0bc1
Migrate resetFrameState
cbracken 42d673b
Migrate createMissingOverlays:
cbracken 70149e0
Migrate performSubmit
cbracken c9153f4
Migrate compositeView:withParams:
cbracken 62495b1
Migrate viewsToDispose
cbracken 02bdf81
Migrate removeUnusedLayers:
cbracken 20be46a
Migreate createLayerWithIosContext:
cbracken ccfc428
Migrate nextLayerInPool
cbracken 1bb3392
Migrate bringLayersIntoView
cbracken 5d706fe
Migrate applyMutators
cbracken 26b3afb
Migrate clipViewSetMaskView
cbracken 894bb07
Migrate constructor
cbracken b1f25d8
Migrate layer_pool
cbracken cc73df9
Migrate slices
cbracken 3461c8c
Migrate flutter_view_, flutter_view_controller_
cbracken a6cab02
Migrate mask_view_pool
cbracken 493ea56
Migrate factories
cbracken 632893d
Migrate gesture_recognizers_blocking_policies
cbracken 46e7de8
frame_size and platform_task_runner
cbracken 728936c
Migrate platform_views
cbracken 22e3a79
Remove unnecessary dynamic decls
cbracken 22aa5da
Migrate current_composition_params
cbracken 1c2931d
Migrate views_to_dispose
cbracken fcda13b
Migrate composition_order
cbracken d31b2f1
Migrate visited_platform_views
cbracken 0f7b7f1
views_to_recomposite
cbracken 035e508
Migrate non_zero_origin_views
cbracken ad329de
Migrate previous_composition order and had_platform_views
cbracken 4ee5b82
FORMAT
cbracken 9184dbb
Reorder
cbracken 7326a7a
Identifier cleanup
cbracken 41f56fb
More identifier renaming
cbracken 94dc77e
Add a TODO
cbracken b44ba77
More renaming
cbracken 1811be2
More renaming
cbracken c50809a
More renaming
cbracken 43a7e95
More renaming
cbracken 93e5fc6
More renaming
cbracken b30daa0
More renames
cbracken cb78b36
Param renaming
cbracken 8085428
More param renaming
cbracken 1348e18
more param renaming
cbracken 19d6bc0
ivar rename but there's no point in this ivar
cbracken b3f053e
Locals
cbracken 6058423
More locals... and done I think
cbracken 6db991b
Format
cbracken File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
More renames
- Loading branch information
commit b30daa0ae5eba42008836e41889a3297c1636aa8
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.