This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Fix include path in fuchsia's analysis_options.yaml files #57203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
platform-fuchsia
platform-web
goderbauer
force-pushed
the
fixAnalysisOptions
branch
from
6898ca2 to
a903276
Compare
goderbauer
changed the title
goderbauer
force-pushed
the
fixAnalysisOptions
branch
from
148c91d to
006acd3
Compare
zanderso
approved these changes
Dec 14, 2024
goderbauer
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 14, 2024
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Dec 14, 2024
flutter/engine@c4e3cc2...4e4a430 2024-12-14 [email protected] Fix include path in fuchsia's analysis_options.yaml files (flutter/engine#57203) 2024-12-13 [email protected] Delete stale package_config.json in gclient sync hook (flutter/engine#57195) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
nick9822
pushed a commit
to nick9822/flutter
that referenced
this pull request
Dec 18, 2024
…gine#57203) The old path doesn't exist. `dart format` stumbles over this non-existent include. `analysis_options.yaml` files that just imported something non-existent were deleted. I am surprised that this never caused any other issues. Is this all dead code that isn't actually analyzed?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old path doesn't exist.
dart formatstumbles over this non-existent include.analysis_options.yamlfiles that just imported something non-existent were deleted.I am surprised that this never caused any other issues. Is this all dead code that isn't actually analyzed?