This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Add checks to constructors and add missing constructor members #9106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jason-simmons
approved these changes
May 28, 2019
This was referenced May 28, 2019
Contributor
|
Docs for |
Contributor
Author
|
Its okay to leave them out, because this code is essentially overwritten
when I sync
…On Tue, Jun 4, 2019 at 3:07 PM Gary Qian ***@***.***> wrote:
Docs for List<FontFeature> fontFeatures, should be added.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#9106?email_source=notifications&email_token=ACEPGCVE7UOTXS4BUWRPB7TPY3RSZA5CNFSM4HQGEWEKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODW6ALQQ#issuecomment-498861506>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACEPGCVVBUAAIGQ7FKW6LRTPY3RSZANCNFSM4HQGEWEA>
.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.