This repository was archived by the owner on Mar 8, 2025. It is now read-only.
Dynamically set engine.version
#62
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
I expect this to fail after the engine is built because the flutter tests are still looking in some other castle / realm |
jtmcdole
commented
Dec 13, 2024
Member
Author
|
Once cocoon and luci changes roll out; we can retry this one and should see tests passing and downloading the correct engine. |
Member
Author
|
Changes rolled out. Will retry this with an empty push |
jason-simmons
approved these changes
Dec 17, 2024
Member
Author
|
I still don't know why Web isn't being built. I'm off of master. |
When running on a bot or release; engine.version should be the HEAD. When running in other cases, engine.version should be based on a commit in master. engine.version shouldn't be tracked - so ci.yaml needs to be updated to look for real changes to the engine.
Member
Author
|
Cocoon & LUCI updated; running a new set of tests after removing non-existing tests. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of tracking
engine.version, dynamically determine its value using the Git hash.The logic for determining the version is as follows:
engine.versionis set to the HEAD commit hash.engine.versionis set to the merge-base between HEAD and the master branch.This change also updates
.ci.yamlto detect actual changes to the engine, rather than relying on the previously trackedengine.versionfile.