[flutter_conductor] Extend timeout for codesign integration test #100940
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
c: contributor-productivity
christopherfujino
requested review from
goderbauer
and removed request for
goderbauer
christopherfujino
force-pushed
the
extend-timeout-for-codesign-integration-test
branch
from
3faf094 to
e2560b2
Compare
CaseyHillers
approved these changes
Mar 29, 2022
|
|
||
| // This test clones the framework and downloads pre-built binaries; it sometimes | ||
| // times out with the default 5 minutes: https://github.com/flutter/flutter/issues/100937 | ||
| @Timeout(Duration(minutes: 10)) |
Contributor
There was a problem hiding this comment.
It seems like the bot got throttled from GitHub and that's why this flakes.
It'd be nice if we could make conductor checkout against GoB, and then set the upstream back to GitHub.
Contributor
Author
There was a problem hiding this comment.
that wouldn't work pre-submit
Contributor
Author
There was a problem hiding this comment.
well, i guess it could fallback.
Contributor
There was a problem hiding this comment.
Wouldn't it work in this case? Or is the assumption this test might have a breaking change where you need the changes in presubmit? If so, we could copy the current framework checkout to a tmp folder.
christopherfujino
deleted the
extend-timeout-for-codesign-integration-test
branch
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Mar 29, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Mar 29, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/plugins
that referenced
this pull request
Mar 29, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Apr 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #100937