Skip to content

[platform_view]Send platform message when platform view is focused #105050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 16 commits into from
Jun 23, 2022
Merged

[platform_view]Send platform message when platform view is focused #105050

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
7c96ac0
[platform_view]Send platform message when platform view is focused
hellohuanlin May 31, 2022
0cf4af5
nits
hellohuanlin Jun 1, 2022
d6ad615
add command line option for driver tests
hellohuanlin Jun 10, 2022
d818763
add fliutter page for focus test
hellohuanlin Jun 10, 2022
9a9cabd
add text field platform view
hellohuanlin Jun 10, 2022
9a2df74
add xcuitest
hellohuanlin Jun 10, 2022
14bd33c
update license
hellohuanlin Jun 10, 2022
babaa34
add ui test for focus
hellohuanlin Jun 10, 2022
ee38b98
add ci task runner
hellohuanlin Jun 10, 2022
d9ee27a
nit
hellohuanlin Jun 10, 2022
5810072
update test owners
hellohuanlin Jun 10, 2022
8199f35
remove the deleted test owner info
hellohuanlin Jun 10, 2022
7633816
update test ci code
hellohuanlin Jun 13, 2022
72e1537
update macios to mac in ci
hellohuanlin Jun 13, 2022
da8faf3
null check for _controller
hellohuanlin Jun 15, 2022
d7667a4
pass controller in focus callback
hellohuanlin Jun 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
pass controller in focus callback
  • Loading branch information
@hellohuanlin
hellohuanlin committed Jun 22, 2022
commit d7667a44c100080e000d186e1da419779fd1f363
14 changes: 5 additions & 9 deletions packages/flutter/lib/src/widgets/platform_view.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -569,12 +569,13 @@ class _UiKitViewState extends State<UiKitView> {

@override
Widget build(BuildContext context) {
if (_controller == null) {
final UiKitViewController? controller = _controller;
if (controller == null) {
return const SizedBox.expand();
}
return Focus(
focusNode: _focusNode,
onFocusChange: _onFocusChange,
onFocusChange: (bool isFocused) => _onFocusChange(isFocused, controller),
child: _UiKitPlatformView(
controller: _controller!,
hitTestBehavior: widget.hitTestBehavior,
Expand Down Expand Up @@ -659,12 +660,7 @@ class _UiKitViewState extends State<UiKitView> {
});
}

void _onFocusChange(bool isFocused) {
assert(_controller != null, 'warning: attempt to focus a UIKitView when it is not ready. ');
if (_controller == null) {
return;
}

void _onFocusChange(bool isFocused, UiKitViewController controller) {
if (!isFocused) {
Copy link
Contributor

@cyanglaz cyanglaz May 31, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nits:
Maybe this would be more readable if we check if (isFocused) first?

if (isFocused) {
  SystemChannels.textInput.invokeMethod<void>(
        'TextInput.setPlatformViewClient',
        <String, dynamic>{'platformViewId': _controller!.id},

}

Or we can escape early instead of if-else

if (!isfocused) {
  return;
}
 SystemChannels.textInput.invokeMethod<void>(
        'TextInput.setPlatformViewClient',
        <String, dynamic>{'platformViewId': _controller!.id},

// Unlike Android, we do not need to send "clearFocus" channel message
// to the engine, because focusing on another view will automatically
Expand All @@ -673,7 +669,7 @@ class _UiKitViewState extends State<UiKitView> {
}
SystemChannels.textInput.invokeMethod<void>(
'TextInput.setPlatformViewClient',
<String, dynamic>{'platformViewId': _controller!.id},
<String, dynamic>{'platformViewId': controller.id},
);
}
}
Expand Down