Skip to content

Add build-after-edit benchmark #107192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aam merged 3 commits into from
Jul 7, 2022
Merged

Add build-after-edit benchmark #107192

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
96ba5ae
Add build-after-edit benchmark
aam Jul 6, 2022
bf34e29
Clean up analyzer warnings
aam Jul 6, 2022
d7889a9
Restore line break
aam Jul 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Clean up analyzer warnings
  • Loading branch information
@aam
aam committed Jul 6, 2022
commit bf34e29f6ac441c03670474e807660c1fade9613
8 changes: 4 additions & 4 deletions dev/devicelab/lib/tasks/perf_tests.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1334,11 +1334,11 @@ class CompileTest {
...compileSecondDebug,
};

final mainDart = File(testDirectory + "/lib/main.dart");
final File mainDart = File('$testDirectory/lib/main.dart');
if (mainDart.existsSync()) {
final bytes = mainDart.readAsBytesSync();
final List<int> bytes = mainDart.readAsBytesSync();
// "Touch" the file
mainDart.writeAsStringSync(" ", mode: FileMode.append, flush: true);
mainDart.writeAsStringSync(' ', mode: FileMode.append, flush: true);
// Build after "edit" without clean should be faster than first build
final Map<String, dynamic> compileAfterEditDebug = await _compileDebug(
clean: false,
Expand All @@ -1347,7 +1347,7 @@ class CompileTest {
metrics.addAll(compileAfterEditDebug);
// Revert the changes
mainDart.writeAsBytesSync(bytes, flush: true);
};
}

return TaskResult.success(metrics, benchmarkScoreKeys: metrics.keys.toList());
});
Expand Down