Skip to content

Cache TextPainter plain text value to improve performance #109841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tgucio merged 25 commits into from
Oct 25, 2022
Merged

Cache TextPainter plain text value to improve performance #109841

Changes from 1 commit
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
09228a9
Cache plain text in TextPainter
tgucio Aug 19, 2022
8ebf720
Use cached TextPainter plain text in Editable and above
tgucio Aug 19, 2022
a97a8a5
Missed change in _getRectFromUpstream
tgucio Aug 19, 2022
42732d3
Update comment
tgucio Aug 19, 2022
17d1f58
Trailing space
tgucio Aug 19, 2022
a091e8d
Handle out of bounds offsets in _getRectFrom*
tgucio Aug 19, 2022
2740136
Merge branch 'flutter:master' into editable-plaintext-cache
tgucio Aug 31, 2022
dbb3a38
Merge remote-tracking branch 'upstream/master' into editable-plaintex…
tgucio Sep 19, 2022
363caf5
Merge branch 'flutter:master' into editable-plaintext-cache
tgucio Sep 19, 2022
ab8d597
Update comment
tgucio Sep 19, 2022
3dc0832
Update comments in editable.dart
tgucio Sep 19, 2022
744a162
Add a test in TextPainter
tgucio Sep 19, 2022
071df5b
Add a test in RenderEditable
tgucio Sep 19, 2022
f3e74f3
Fix after merge
tgucio Sep 19, 2022
bc87f6e
Fix analyzer warnings
tgucio Sep 19, 2022
0062e7e
More analyzer warnings
tgucio Sep 20, 2022
bea8460
Handle null text
tgucio Sep 20, 2022
cd72e52
Pass placeholder dimensions for test
tgucio Sep 20, 2022
f8e0071
Remove extra newline
tgucio Oct 5, 2022
57fbadf
Merge branch 'master' into editable-plaintext-cache
tgucio Oct 5, 2022
f876832
Fix merge error
tgucio Oct 5, 2022
4a8f699
Merge branch 'flutter:master' into editable-plaintext-cache
tgucio Oct 6, 2022
782e462
Remove trailing spaces
tgucio Oct 6, 2022
e70e455
Merge branch 'flutter:master' into editable-plaintext-cache
tgucio Oct 14, 2022
a6e7526
Merge branch 'master' into editable-plaintext-cache
tgucio Oct 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Merge branch 'flutter:master' into editable-plaintext-cache
  • Loading branch information
@tgucio
tgucio authored Oct 6, 2022
commit 4a8f699c668d61464d16a98841ee8e1b33cd3602

This merge commit was added into this branch cleanly.

There are no new changes to show, but you can still view the diff.