Check all possible output directories to find a locally built gen_snapshot #11417
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pshot The output location of gen_snapshot differs based on the engine's target platform, and we don't know the target platform when building a platform-independent FLX in JIT mode.
yjbanov
approved these changes
Jul 27, 2017
| return genSnapshotPath; | ||
| } | ||
| return fs.path.join(engineOutPath, clang, _artifactToFileName(Artifact.genSnapshot)); | ||
| throw new Exception('Unable to find $genSnapshotName'); |
There was a problem hiding this comment.
We'd want to make sure that this results in a tool crash with a crash report. Could you please check that that's what happens?
Also, do we expect that this line should never be reached? If so, we should throw a longer message saying that this is likely a bug in Flutter and invite the user to file an issue. Here's an example.
There was a problem hiding this comment.
Yes - this is an exception that generates a "Flutter crash report" log.
This function runs when you are building a debug mode JIT snapshot with a locally built engine. If it throws, it means that something is wrong with your local engine build output. It may or may not be a bug in flutter_tools or in the engine build process.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The output location of gen_snapshot differs based on the engine's target
platform, and we don't know the target platform when building a
platform-independent FLX in JIT mode.