Skip to content

Allow Flutter golden file tests to be flaky #114450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 18 commits into from
Nov 8, 2022
Merged

Allow Flutter golden file tests to be flaky #114450

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
4cc45f9
allow marking a golden check as flaky
yjbanov Oct 26, 2022
e7e1d7e
add matchesFlutterGolden to analyze.dart; no tags for flutter_goldens…
yjbanov Oct 27, 2022
f800740
Merge branch 'flaky-golden-api-2' of https://github.com/yjbanov/flutt…
Piinks Nov 1, 2022
3102ed7
Pause
Piinks Nov 1, 2022
a321c28
++
Piinks Nov 1, 2022
c5e1fda
++
Piinks Nov 1, 2022
fe6eb5a
Analyzer therapy
Piinks Nov 1, 2022
a24fb95
Once more with feeling
Piinks Nov 1, 2022
6cd652a
Nits
Piinks Nov 1, 2022
d0a8ff6
Review feedback
Piinks Nov 2, 2022
e52b022
Silly oops
Piinks Nov 2, 2022
72b69c0
Test progress
Piinks Nov 4, 2022
28b4fa0
More tests
Piinks Nov 5, 2022
b131b38
Finish
Piinks Nov 7, 2022
553c16d
Nits
Piinks Nov 7, 2022
51213b0
Analyzer
Piinks Nov 8, 2022
3e88c94
Review feedback
Piinks Nov 8, 2022
dc9e496
Merge branch 'master' of github.com:flutter/flutter into goldenFlake3
Piinks Nov 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Once more with feeling
  • Loading branch information
@Piinks
Piinks committed Nov 1, 2022
commit a24fb954035530def43e8658356d42c8c847a160
2 changes: 1 addition & 1 deletion dev/bots/analyze.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -418,7 +418,7 @@ Future<void> verifyNoSyncAsyncStar(String workingDirectory, {int minimumMatches
}
}

final RegExp _findGoldenTestPattern = RegExp(r'(matchesGoldenFile|matchesFlutterGolden)\(');
final RegExp _findGoldenTestPattern = RegExp(r'(matchesGoldenFile|expectFlakyGolden)\(');
final RegExp _findGoldenDefinitionPattern = RegExp(r'matchesGoldenFile\(Object');
final RegExp _leadingComment = RegExp(r'//');
final RegExp _goldenTagPattern1 = RegExp(r'@Tags\(');
Expand Down
1 change: 0 additions & 1 deletion packages/flutter/test/cupertino/date_picker_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ import 'package:flutter_goldens/flutter_goldens.dart' show expectFlakyGolden;
import 'package:flutter_test/flutter_test.dart';

// TODO(yjbanov): on the web text rendered with perspective produces flaky goldens: https://github.com/flutter/flutter/issues/110785
const bool perspectiveTextIsFlaky = isBrowser;

// A number of the hit tests below say "warnIfMissed: false". This is because
// the way the CupertinoPicker works, the hits don't actually reach the labels,
Expand Down