-
Notifications
You must be signed in to change notification settings - Fork 29.8k
Add Java-Gradle-AGP validation to flutter analyze #123916
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
reidbaker
merged 68 commits into
flutter:master
from
reidbaker:i122376-warn-on-gradle-java-AGP-incompatiblilty
Apr 5, 2023
Merged
Changes from 1 commit
Commits
Show all changes
68 commits
Select commit
Hold shift + click to select a range
a07f7ee
Add function to gradle_utils.dart that gets the gradle version from w…
reidbaker 7b4f418
Add validator that alwasys returns false and test, plus todo in integ…
reidbaker 2b95eb5
Update documentation, add constants in gradle_utils.dart
reidbaker 477734e
Add method to get agp version, add method to validate agp against gra…
reidbaker 5a8005a
Add task to projects evaluated by flutter.gradle that will print the …
reidbaker e05aa96
Merge branch 'master' into i122376-warn-on-gradle-java-AGP-incompatib…
reidbaker 53e89a0
Update dart doc for validateGradleAndAgp to describe where the info c…
reidbaker af3c647
Fill out and test java gradle compatability function in gradle_utils
reidbaker 7e643a6
Hook up java gradle evaluateion to hasValidJavaGradleAgpVersions with…
reidbaker 6b4ed1b
Add java --version output parsing and tests
reidbaker 96cae3d
Add getJavaBinary test
reidbaker 5e08847
Update comment in android_sdk for mac behavior with java_home -v
reidbaker b263dfc
Update format of group java/gradle/agp tests to have one test per pai…
reidbaker 1a5e9e1
Handle mid java values
reidbaker 4749a95
pre review feedback and cleanup of todos
reidbaker fff074e
Undo formatting
reidbaker 2df3691
Undo formatting 2
reidbaker 3815b0c
Add fake AndroidStudio and more formatting fixes
reidbaker 21b8887
remove hardcoded values
reidbaker 87ea610
make getJavaVersion callable
reidbaker 7bc2f4b
Undo accidental revert of project.dart using java version
reidbaker 565dd58
Add validator to list
reidbaker 51903c4
Update analyze suggetions integration test with java/gradle/agp confi…
reidbaker a84e4b6
Add window java output test
reidbaker c2df14e
copyright formatting
reidbaker 453889c
Make isWithinVersionRange public and move it as a static helper in ve…
reidbaker 07213fb
Add tests to isWithinVersionRange
reidbaker 860b861
Make maxKnownAgpVersion visible for testing, and use it in a test, ma…
reidbaker 8d379d6
Merge branch 'master' into i122376-warn-on-gradle-java-AGP-incompatib…
reidbaker 54d1b99
dart fix --apply
reidbaker 6ce48fe
Update error description to have better formatting
reidbaker 2641a53
Return better result value from java/gradle/agp validation with descr…
reidbaker ad94e9b
Addd test for java/gradle/agp validation test is failing
reidbaker 3a8dc54
Add passing test for java/gradle/agp in project_test
reidbaker 9295069
Add expected passing compatibility tests
reidbaker f9d61ba
Add failing cases and check string description
reidbaker cd20ff2
dart fix --apply
reidbaker 0e45f6f
Undo some auto formatting to make reviewing easier
reidbaker 5bc570c
Make getVersion non static and update tests
reidbaker b3823a5
Remove dead code replaces by overriding java version in fake
reidbaker 0fb85f4
Merge branch 'master' into i122376-warn-on-gradle-java-AGP-incompatib…
reidbaker 0c66529
remove dead code, use constants when avilable, fix todo formatting
reidbaker 2484666
Remove no longer used filesystem
reidbaker dab39a0
Add --verbose to get logs to debug test/integration.shard/analyze_sug…
reidbaker 42092ee
Merge branch 'master' into i122376-warn-on-gradle-java-AGP-incompatib…
reidbaker 77db98e
Add dart doc to parseJavaVersion, updated regex to support optional t…
reidbaker 69f7fb9
Add whitespace test on gradle format
reidbaker 221f2e6
Review comments, spelling and an additional test to cover -beta and -…
reidbaker ab0e2e6
spelling, using late in testing to avoid test polution
reidbaker 6d0268d
Formatting and reduction in test polution by isolating variable scope
reidbaker ee8ccb6
remove unused variable
reidbaker 5b10e19
Add test for specific version output of ci https://chrome-infra-packa…
reidbaker 09adddc
Update gradle version so that java version and gradle are compatible
reidbaker 09c2c97
Review feedback
reidbaker fa7da03
spelling fix
reidbaker 7f50a6f
Print trace logging for getJavaVersion and getJavaBinary
reidbaker 76aa064
Make tests that depend on logger use testUsingContext
reidbaker 64c7b8e
Fix todo format
reidbaker 9f03e54
Merge branch 'master' into i122376-warn-on-gradle-java-AGP-incompatib…
reidbaker 033cd4b
Reformat java/gradle compat to use a class and be a list
reidbaker a749ad8
Reformat todo
reidbaker 7ba52c0
Merge branch 'master' into i122376-warn-on-gradle-java-AGP-incompatib…
reidbaker ae705bf
formatting and dart docs
reidbaker 6e69b85
Handle newer patch versions of java and gradle and add test to cover
reidbaker da7b866
dart docs and formatting
reidbaker e0572ac
spelling fix
reidbaker 3165cbf
Merge branch 'master' into i122376-warn-on-gradle-java-AGP-incompatib…
reidbaker deb320f
Make test value final
reidbaker File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
remove dead code, use constants when avilable, fix todo formatting
- Loading branch information
commit 0c6652901a81eab1b4e0b2f13d5ae526014f2a87
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.