Skip to content

Fix the position of the Android-style spell check toolbar #124897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
justinmc merged 14 commits into from
Apr 24, 2023
Merged

Fix the position of the Android-style spell check toolbar #124897

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
2df9c55
Fix the position of the Android-style spell check toolbar
justinmc Apr 14, 2023
07a75e9
Merge branch 'master' into spell-check-material-position
justinmc Apr 18, 2023
bea9a8f
Fix a typo
justinmc Apr 18, 2023
3ad3fa7
Hide the selection handles when showing the spell check toolbar
justinmc Apr 18, 2023
5eb881c
Adjust failing tests to new menu position
justinmc Apr 18, 2023
72d6702
Test handle visibility
justinmc Apr 18, 2023
ff3aa4d
Analyzer
justinmc Apr 18, 2023
ed96a11
Merge branch 'master' into spell-check-material-position
justinmc Apr 19, 2023
24848b1
Merge branch 'master' into spell-check-material-position
justinmc Apr 19, 2023
f517e95
Test shouldn't use Cupertino
justinmc Apr 19, 2023
7f81222
Merge branch 'master' into spell-check-material-position
justinmc Apr 20, 2023
01a050d
No kToolbarContentDistanceBelow. Toolbar should be right under the word
justinmc Apr 20, 2023
e5b4ae1
Analyzer
justinmc Apr 20, 2023
aa6ae87
Merge branch 'master' into spell-check-material-position
justinmc Apr 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Adjust failing tests to new menu position
  • Loading branch information
@justinmc
justinmc committed Apr 18, 2023
commit 5eb881c48f0b88149f11045b47cecda8da8730fb
9 changes: 5 additions & 4 deletions packages/flutter/test/material/spell_check_suggestions_toolbar_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,8 @@ void main() {

testWidgets('positions toolbar below anchor when it fits above bottom view padding', (WidgetTester tester) async {
// We expect the toolbar to be positioned right below the anchor with padding accounted for.
const double expectedToolbarY =
_kAnchor + (2 * SpellCheckSuggestionsToolbar.kToolbarContentDistanceBelow) - CupertinoTextSelectionToolbar.kToolbarScreenPadding;
const double expectedToolbarY = _kAnchor
+ SpellCheckSuggestionsToolbar.kToolbarContentDistanceBelow;

await tester.pumpWidget(
MaterialApp(
Expand All @@ -69,8 +69,9 @@ void main() {

testWidgets('re-positions toolbar higher below anchor when it does not fit above bottom view padding', (WidgetTester tester) async {
// We expect the toolbar to be positioned _kTestToolbarOverlap pixels above the anchor with padding accounted for.
const double expectedToolbarY =
_kAnchor + (2 * SpellCheckSuggestionsToolbar.kToolbarContentDistanceBelow) - CupertinoTextSelectionToolbar.kToolbarScreenPadding - _kTestToolbarOverlap;
const double expectedToolbarY = _kAnchor
+ SpellCheckSuggestionsToolbar.kToolbarContentDistanceBelow
- _kTestToolbarOverlap;

await tester.pumpWidget(
MaterialApp(
Expand Down