Skip to content
Merged
Changes from 1 commit
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
a482feb
Fix selecting a word
Renzo-Olivares Oct 19, 2023
696f18c
remove logs
Renzo-Olivares Oct 19, 2023
cd2d0f2
revert erroneous changes
Renzo-Olivares Oct 19, 2023
c0240cb
Update comments
Renzo-Olivares Oct 19, 2023
1b0bea1
Update screen order comparison logic
Renzo-Olivares Oct 19, 2023
8f843d3
go to next/prev when word boundary is at edge of the selectable fragm…
Renzo-Olivares Oct 19, 2023
927121f
fix analyzer
Renzo-Olivares Oct 19, 2023
a7c174b
Add isInlineWidget to text widgets
Renzo-Olivares Oct 20, 2023
02e20a3
Add more tests
Renzo-Olivares Oct 20, 2023
513a539
Add docs
Renzo-Olivares Oct 20, 2023
cb55c19
clean up comments
Renzo-Olivares Oct 20, 2023
c9a6d1c
fix analyzer
Renzo-Olivares Oct 20, 2023
a1d8b56
When moving the selection edge by word boundary we should invalidate …
Renzo-Olivares Oct 23, 2023
a743815
clean up logic
Renzo-Olivares Oct 23, 2023
ae974c1
Add double click drag tests when widget span is involved
Renzo-Olivares Oct 23, 2023
f9dbdc0
remove isInlineWidget and isFollowedByInlineElement
Renzo-Olivares Nov 17, 2023
24c58f2
updats
Renzo-Olivares Nov 17, 2023
1696f3f
Add Diagnosticable support for _SelectableFragment
Renzo-Olivares Nov 17, 2023
e2a2d70
fix
Renzo-Olivares Nov 17, 2023
069f53b
introduce granularRects for selectable
Renzo-Olivares Nov 18, 2023
9f5f95f
make analyzer happy
Renzo-Olivares Nov 21, 2023
a4f5b35
granularRects -> boundingBoxes, boundingBoxes are in local coordinates
Renzo-Olivares Dec 4, 2023
7dd79d3
update examples
Renzo-Olivares Dec 4, 2023
d410471
fix analyzer
Renzo-Olivares Dec 4, 2023
0d9ebfd
update docs
Renzo-Olivares Dec 5, 2023
e1d9ab4
fix test
Renzo-Olivares Dec 6, 2023
863d675
updates
Renzo-Olivares Dec 6, 2023
cb95515
revert screen order sorting changes
Renzo-Olivares Dec 7, 2023
20ab1e3
fix selection overlay dragging / positioning
Renzo-Olivares Dec 7, 2023
e9ef8c0
updates
Renzo-Olivares Dec 7, 2023
c0c4bcf
updates
Renzo-Olivares Dec 7, 2023
07d09b1
fix test
Renzo-Olivares Dec 7, 2023
71bb8c8
update tests
Renzo-Olivares Dec 7, 2023
27bb2af
Address comments
Renzo-Olivares Dec 11, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
updates
  • Loading branch information
Renzo-Olivares committed Dec 7, 2023
commit 863d675e012c1880434b9f3cff2df2db95535911
2 changes: 1 addition & 1 deletion packages/flutter/lib/src/rendering/paragraph.dart
Original file line number Diff line number Diff line change
Expand Up @@ -2002,7 +2002,7 @@ class _SelectableFragment with Selectable, Diagnosticable, ChangeNotifier implem
if (_cachedBoundingBoxes == null) {
final List<TextBox> boxes = paragraph.getBoxesForSelection(
TextSelection(baseOffset: range.start, extentOffset: range.end),
);// Maybe we can re-use the getBoxesForSelections results in `_rect`.
);
if (boxes.isNotEmpty) {
_cachedBoundingBoxes = <Rect>[];
for (final TextBox textBox in boxes) {
Expand Down