Skip to content

[devicelab] migrate new gallery benchmarks to local copy. #143545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 2 commits into from
Feb 15, 2024
Merged

[devicelab] migrate new gallery benchmarks to local copy. #143545

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f64e1e2
[devicelab] migrate new gallery benchmarks to local copy.
Feb 15, 2024
395aed4
fix directory referencs.
Feb 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix directory referencs.
  • Loading branch information
jonahwilliams committed Feb 15, 2024
commit 395aed435b7f55432adb1a4d7b34169af141e991
8 changes: 4 additions & 4 deletions dev/devicelab/bin/tasks/flutter_gallery_v2_chrome_run_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,15 +32,15 @@ class NewGalleryChromeRunTest {

/// Runs the test.
Future<TaskResult> run() async {
final TaskResult result = await inDirectory<TaskResult>('dev/integration_tests/new_gallery', () async {
await flutter('doctor');
await flutter('packages', options: <String>['get']);
final TaskResult result = await inDirectory<TaskResult>('${flutterDirectory.path}/dev/integration_tests/new_gallery/', () async {
await flutter('create', options: <String>[
'--platforms',
'web',
'web,android,ios',
'--no-overwrite',
'.'
]);
await flutter('doctor');
await flutter('packages', options: <String>['get']);

await flutter('build', options: <String>[
'web',
Expand Down
8 changes: 4 additions & 4 deletions dev/devicelab/bin/tasks/flutter_gallery_v2_web_compile_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,19 +21,19 @@ class NewGalleryWebCompileTest {
/// Runs the test.
Future<TaskResult> run() async {
final Map<String, Object> metrics = await inDirectory<Map<String, int>>(
'dev/integration_tests/new_gallery',
'${flutterDirectory.path}/dev/integration_tests/new_gallery/',
() async {
await flutter('doctor');

await flutter('create', options: <String>[
await flutter('create', options: <String>[
'--platforms',
'web',
'web,android,ios',
'--no-overwrite',
'.'
]);

return WebCompileTest.runSingleBuildTest(
directory: 'dev/integration_tests/new_gallery',
directory: '${flutterDirectory.path}/dev/integration_tests/new_gallery/',
metric: metricKeyPrefix,
measureBuildTime: true,
);
Expand Down
5 changes: 3 additions & 2 deletions dev/devicelab/lib/tasks/new_gallery.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

import '../framework/utils.dart';
import 'perf_tests.dart';

class NewGalleryPerfTest extends PerfTest {
Expand All @@ -12,10 +13,10 @@ class NewGalleryPerfTest extends PerfTest {
super.timeoutSeconds,
super.forceOpenGLES,
}) : super(
'dev/integration_tests/new_gallery',
'${flutterDirectory.path}/dev/integration_tests/new_gallery',
'test_driver/transitions_perf.dart',
timelineFileName,
dartDefine: dartDefine,
createPlatforms: ['android', 'ios', 'web']
createPlatforms: <String>['android', 'ios', 'web']
);
}