Skip to content

Fix memory leaks in Hero widget [prod-leak-fix] #147303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
polina-c merged 4 commits into from
Apr 25, 2024
Merged

Fix memory leaks in Hero widget [prod-leak-fix] #147303

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a3c3b2e
fix: Fix leak memories in Hero widget
ValentinVignal Apr 24, 2024
f508433
test: Update the tests
ValentinVignal Apr 24, 2024
db7a3d3
fix: Add mustCallSuper
ValentinVignal Apr 25, 2024
6b8d682
Merge remote-tracking branch 'upstream/main' into flutter/leak-tracki…
ValentinVignal Apr 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: Update the tests
  • Loading branch information
@ValentinVignal
ValentinVignal committed Apr 24, 2024
commit f50843319d97c99fb683150b388b0dedc032be06
5 changes: 4 additions & 1 deletion packages/flutter/test/widgets/heroes_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,7 +301,10 @@ Future<void> main() async {
expect(find.byKey(thirdKey), isInCard);
});

testWidgets('Heroes still animate after hero controller is swapped.', (WidgetTester tester) async {
testWidgets('Heroes still animate after hero controller is swapped.',
// TODO(polina-c): remove when fixed https://github.com/flutter/flutter/issues/145600 [leak-tracking-opt-in]
experimentalLeakTesting: LeakTesting.settings.withTracked(classes: const <String>['CurvedAnimation']),
(WidgetTester tester) async {
final GlobalKey<NavigatorState> key = GlobalKey<NavigatorState>();
final UniqueKey heroKey = UniqueKey();
final HeroController controller1 = HeroController();
Expand Down