Skip to content

Fix flakiness in hot_reload_test.dart #158271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 1 commit into from
Nov 6, 2024
Merged

Fix flakiness in hot_reload_test.dart #158271

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion packages/flutter_tools/test/integration.shard/hot_reload_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,11 +69,21 @@ void main() {

testWithoutContext('newly added code executes during hot reload', () async {
final StringBuffer stdout = StringBuffer();
final StreamSubscription<String> subscription = flutter.stdout.listen(stdout.writeln);
final Completer<void> completer = Completer<void>();
final StreamSubscription<String> subscription = flutter.stdout.listen((String e) {
stdout.writeln(e);
// If hot reload properly executes newly added code, the 'RELOAD WORKED' message should
// be printed before 'TICK 2'. If we don't wait for some signal that the build method
// has executed after the reload, this test can encounter a race.
if (e.contains('((((TICK 2))))')) {
completer.complete();
}
});
await flutter.run();
project.uncommentHotReloadPrint();
try {
await flutter.hotReload();
await completer.future;
expect(stdout.toString(), contains('(((((RELOAD WORKED)))))'));
} finally {
await subscription.cancel();
Expand Down