Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Support ignoring pointer events on tooltip overlay (#142465)
  • Loading branch information
benji-farquhar committed Feb 4, 2025
commit 53e3c29d2abe12f338d39c41b1d33a4ed390b042
17 changes: 16 additions & 1 deletion packages/flutter/lib/src/material/tooltip.dart
Original file line number Diff line number Diff line change
Expand Up @@ -186,6 +186,7 @@ class Tooltip extends StatefulWidget {
this.enableFeedback,
this.onTriggered,
this.mouseCursor,
this.ignorePointer,
this.child,
}) : assert(
(message == null) != (richMessage == null),
Expand Down Expand Up @@ -363,6 +364,17 @@ class Tooltip extends StatefulWidget {
/// If this property is null, [MouseCursor.defer] will be used.
final MouseCursor? mouseCursor;

/// Whether this tooltip should be invisible to hit testing.
///
/// If no value is passed, pointer events are ignored unless the tooltip has a
/// [richMessage] instead of a [message].
///
/// See also:
///
/// * [IgnorePointer], for more information about how pointer events are
/// handled or ignored.
final bool? ignorePointer;

static final List<TooltipState> _openedTooltips = <TooltipState>[];

/// Dismiss all of the tooltips that are currently shown on the screen,
Expand Down Expand Up @@ -846,6 +858,7 @@ class TooltipState extends State<Tooltip> with SingleTickerProviderStateMixin {
verticalOffset:
widget.verticalOffset ?? tooltipTheme.verticalOffset ?? _defaultVerticalOffset,
preferBelow: widget.preferBelow ?? tooltipTheme.preferBelow ?? _defaultPreferBelow,
ignorePointer: widget.ignorePointer ?? widget.message != null,
);

return SelectionContainer.maybeOf(context) == null
Expand Down Expand Up @@ -971,6 +984,7 @@ class _TooltipOverlay extends StatelessWidget {
required this.target,
required this.verticalOffset,
required this.preferBelow,
required this.ignorePointer,
this.onEnter,
this.onExit,
});
Expand All @@ -988,6 +1002,7 @@ class _TooltipOverlay extends StatelessWidget {
final bool preferBelow;
final PointerEnterEventListener? onEnter;
final PointerExitEventListener? onExit;
final bool ignorePointer;

@override
Widget build(BuildContext context) {
Expand Down Expand Up @@ -1024,7 +1039,7 @@ class _TooltipOverlay extends StatelessWidget {
verticalOffset: verticalOffset,
preferBelow: preferBelow,
),
child: result,
child: IgnorePointer(ignoring: ignorePointer, child: result),
),
);
}
Expand Down
176 changes: 174 additions & 2 deletions packages/flutter/test/material/tooltip_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -1403,7 +1403,8 @@ void main() {
});

testWidgets('Tooltip is dismissed after tap to dismiss immediately', (WidgetTester tester) async {
await setWidgetForTooltipMode(tester, TooltipTriggerMode.tap);
// This test relies on not ignoring pointer events.
await setWidgetForTooltipMode(tester, TooltipTriggerMode.tap, ignorePointer: false);

final Finder tooltip = find.byType(Tooltip);
expect(find.text(tooltipText), findsNothing);
Expand All @@ -1421,7 +1422,13 @@ void main() {
testWidgets('Tooltip is not dismissed after tap if enableTapToDismiss is false', (
WidgetTester tester,
) async {
await setWidgetForTooltipMode(tester, TooltipTriggerMode.tap, enableTapToDismiss: false);
// This test relies on not ignoring pointer events.
await setWidgetForTooltipMode(
tester,
TooltipTriggerMode.tap,
enableTapToDismiss: false,
ignorePointer: false,
);

final Finder tooltip = find.byType(Tooltip);
expect(find.text(tooltipText), findsNothing);
Expand Down Expand Up @@ -1727,6 +1734,8 @@ void main() {
const MaterialApp(
home: Center(
child: Tooltip(
// This test relies on not ignoring pointer events.
ignorePointer: false,
message: tooltipText,
waitDuration: waitDuration,
child: Text('I am tool tip'),
Expand Down Expand Up @@ -3220,6 +3229,167 @@ void main() {
await tester.pump();
expect(RendererBinding.instance.mouseTracker.debugDeviceActiveCursor(1), customCursor);
});

testWidgets('Tooltip overlay ignores pointer by default when passing simple message', (
WidgetTester tester,
) async {
const String tooltipMessage = 'Tooltip message';

await tester.pumpWidget(
MaterialApp(
home: Scaffold(
body: Center(
child: Tooltip(
message: tooltipMessage,
child: ElevatedButton(onPressed: () {}, child: const Text('Hover me')),
),
),
),
),
);

final Finder buttonFinder = find.text('Hover me');
expect(buttonFinder, findsOneWidget);

final TestGesture gesture = await tester.createGesture(kind: PointerDeviceKind.mouse);
await gesture.addPointer();
await gesture.moveTo(tester.getCenter(buttonFinder));
await tester.pumpAndSettle();

final Finder tooltipFinder = find.text(tooltipMessage);
expect(tooltipFinder, findsOneWidget);

final Finder ignorePointerFinder = find.byType(IgnorePointer);

final IgnorePointer ignorePointer = tester.widget<IgnorePointer>(ignorePointerFinder.last);
expect(ignorePointer.ignoring, isTrue);

await gesture.removePointer();
});

testWidgets(
"Tooltip overlay with simple message doesn't ignore pointer when passing ignorePointer: false",
(WidgetTester tester) async {
const String tooltipMessage = 'Tooltip message';

await tester.pumpWidget(
MaterialApp(
home: Scaffold(
body: Center(
child: Tooltip(
ignorePointer: false,
message: tooltipMessage,
child: ElevatedButton(onPressed: () {}, child: const Text('Hover me')),
),
),
),
),
);

final Finder buttonFinder = find.text('Hover me');
expect(buttonFinder, findsOneWidget);

final TestGesture gesture = await tester.createGesture(kind: PointerDeviceKind.mouse);
await gesture.addPointer();
await gesture.moveTo(tester.getCenter(buttonFinder));
await tester.pumpAndSettle();

final Finder tooltipFinder = find.text(tooltipMessage);
expect(tooltipFinder, findsOneWidget);

final Finder ignorePointerFinder = find.byType(IgnorePointer);

final IgnorePointer ignorePointer = tester.widget<IgnorePointer>(ignorePointerFinder.last);
expect(ignorePointer.ignoring, isFalse);

await gesture.removePointer();
},
);

testWidgets("Tooltip overlay doesn't ignore pointer by default when passing rich message", (
WidgetTester tester,
) async {
const InlineSpan richMessage = TextSpan(
children: <InlineSpan>[
TextSpan(text: 'Rich ', style: TextStyle(fontWeight: FontWeight.bold)),
TextSpan(text: 'Tooltip'),
],
);

await tester.pumpWidget(
MaterialApp(
home: Scaffold(
body: Center(
child: Tooltip(
richMessage: richMessage,
child: ElevatedButton(onPressed: () {}, child: const Text('Hover me')),
),
),
),
),
);

final Finder buttonFinder = find.text('Hover me');
expect(buttonFinder, findsOneWidget);

final TestGesture gesture = await tester.createGesture(kind: PointerDeviceKind.mouse);
await gesture.addPointer();
await gesture.moveTo(tester.getCenter(buttonFinder));
await tester.pumpAndSettle();

final Finder tooltipFinder = find.textContaining('Rich Tooltip');
expect(tooltipFinder, findsOneWidget);

final Finder ignorePointerFinder = find.byType(IgnorePointer);

final IgnorePointer ignorePointer = tester.widget<IgnorePointer>(ignorePointerFinder.last);
expect(ignorePointer.ignoring, isFalse);

await gesture.removePointer();
});

testWidgets('Tooltip overlay with richMessage ignores pointer when passing ignorePointer: true', (
WidgetTester tester,
) async {
const InlineSpan richMessage = TextSpan(
children: <InlineSpan>[
TextSpan(text: 'Rich ', style: TextStyle(fontWeight: FontWeight.bold)),
TextSpan(text: 'Tooltip'),
],
);

await tester.pumpWidget(
MaterialApp(
home: Scaffold(
body: Center(
child: Tooltip(
ignorePointer: true,
richMessage: richMessage,
child: ElevatedButton(onPressed: () {}, child: const Text('Hover me')),
),
),
),
),
);

final Finder buttonFinder = find.text('Hover me');
expect(buttonFinder, findsOneWidget);

final TestGesture gesture = await tester.createGesture(kind: PointerDeviceKind.mouse);
await gesture.addPointer();
await gesture.moveTo(tester.getCenter(buttonFinder));
await tester.pumpAndSettle();

final Finder tooltipFinder = find.textContaining('Rich Tooltip');
expect(tooltipFinder, findsOneWidget);

final Finder ignorePointerFinder = find.byType(IgnorePointer);

final IgnorePointer ignorePointer = tester.widget<IgnorePointer>(ignorePointerFinder.last);
expect(ignorePointer.ignoring, isTrue);

await gesture.removePointer();
});
}

Future<void> setWidgetForTooltipMode(
Expand All @@ -3228,6 +3398,7 @@ Future<void> setWidgetForTooltipMode(
Duration? showDuration,
bool? enableTapToDismiss,
TooltipTriggeredCallback? onTriggered,
bool? ignorePointer,
}) async {
await tester.pumpWidget(
MaterialApp(
Expand All @@ -3237,6 +3408,7 @@ Future<void> setWidgetForTooltipMode(
onTriggered: onTriggered,
showDuration: showDuration,
enableTapToDismiss: enableTapToDismiss ?? true,
ignorePointer: ignorePointer,
child: const SizedBox(width: 100.0, height: 100.0),
),
),
Expand Down