Skip to content

[web] Gracefully handle empty ui.Vertices #162461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 7 commits into from
Jan 31, 2025
Merged

[web] Gracefully handle empty ui.Vertices #162461

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a5c8266
[web] Handle empty ui.Vertices gracefully
harryterkelsen Jan 30, 2025
b682747
Fix formatting
harryterkelsen Jan 30, 2025
8e6d9c5
Rename isEmpty -> hasNoPoints
harryterkelsen Jan 30, 2025
cdbe968
Run formatter
harryterkelsen Jan 30, 2025
1afce17
Turn off formatting for boolean expression where dart format is weird
harryterkelsen Jan 30, 2025
04f195f
Merge branch 'master' into canvaskit-fix-empty-vertices
harryterkelsen Jan 30, 2025
35d8d3f
Merge branch 'master' into canvaskit-fix-empty-vertices
harryterkelsen Jan 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix formatting
  • Loading branch information
@harryterkelsen
harryterkelsen committed Jan 30, 2025
commit b682747511e8b0be667ce2c62205e92014cb741c
5 changes: 3 additions & 2 deletions engine/src/flutter/lib/web_ui/lib/src/engine/html/bitmap_canvas.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -948,8 +948,9 @@ class BitmapCanvas extends EngineCanvas {
// in the first place.
paragraph.canDrawOnCanvas &&
// Cannot composite if there's no bitmap canvas to composite into.
// Creating a new bitmap canvas just to draw text doesn't make sense.
_canvasPool.hasCanvas &&
// Creating a new bitmap canvas just to draw text doesn't make sense.
_canvasPool
.hasCanvas &&
!_childOverdraw &&
// Bitmap canvas introduces correctness issues in the presence of SVG
// filters, so prefer plain HTML in this case.
Expand Down